Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: chrome/browser/android/tab/thumbnail_tab_helper_android.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/signin/signin_manager_android.cc ('k') | chrome/browser/android/tab_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/tab/thumbnail_tab_helper_android.cc
diff --git a/chrome/browser/android/tab/thumbnail_tab_helper_android.cc b/chrome/browser/android/tab/thumbnail_tab_helper_android.cc
index 3c6328fda4b048855d0e7ec570dfc86723344731..17c0cae8169c2d792073b7bcd930981310846546 100644
--- a/chrome/browser/android/tab/thumbnail_tab_helper_android.cc
+++ b/chrome/browser/android/tab/thumbnail_tab_helper_android.cc
@@ -28,8 +28,8 @@ bool RegisterThumbnailTabHelperAndroid(JNIEnv* env) {
}
static void InitThumbnailHelper(JNIEnv* env,
- jclass clazz,
- jobject jweb_contents) {
+ const JavaParamRef<jclass>& clazz,
+ const JavaParamRef<jobject>& jweb_contents) {
content::WebContents* web_contents =
content::WebContents::FromJavaWebContents(jweb_contents);
DCHECK(web_contents);
@@ -44,8 +44,10 @@ static void InitThumbnailHelper(JNIEnv* env,
thumbnail_tab_helper->set_enabled(false);
}
-static jboolean ShouldUpdateThumbnail(
- JNIEnv* env, jclass clazz, jobject jprofile, jstring jurl) {
+static jboolean ShouldUpdateThumbnail(JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ const JavaParamRef<jobject>& jprofile,
+ const JavaParamRef<jstring>& jurl) {
Profile* profile = ProfileAndroid::FromProfileAndroid(jprofile);
GURL url(base::android::ConvertJavaStringToUTF8(env, jurl));
@@ -56,9 +58,9 @@ static jboolean ShouldUpdateThumbnail(
}
static void UpdateThumbnail(JNIEnv* env,
- jclass clazz,
- jobject jweb_contents,
- jobject bitmap,
+ const JavaParamRef<jclass>& clazz,
+ const JavaParamRef<jobject>& jweb_contents,
+ const JavaParamRef<jobject>& bitmap,
jboolean jat_top) {
content::WebContents* web_contents =
content::WebContents::FromJavaWebContents(jweb_contents);
« no previous file with comments | « chrome/browser/android/signin/signin_manager_android.cc ('k') | chrome/browser/android/tab_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698