chrome/browser/android/signin/signin_manager_android.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/signin/signin_manager_android.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/signin/account_management_screen_helper.cc ('k') | chrome/browser/android/tab/thumbnail_tab_helper_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/signin/signin_manager_android.cc

diff --git a/chrome/browser/android/signin/signin_manager_android.cc b/chrome/browser/android/signin/signin_manager_android.cc

index 3dadad8cc36e5e25d6c804812d0adf4ff3e98a4a..e078206881924c9ca9c4ddb680861bbc3125c13d 100644

--- a/chrome/browser/android/signin/signin_manager_android.cc

+++ b/chrome/browser/android/signin/signin_manager_android.cc

@@ -284,15 +284,16 @@ void SigninManagerAndroid::OnSigninAllowedPrefChanged() {

SigninManagerFactory::GetForProfile(profile_)->IsSigninAllowed());

}

-static jlong Init(JNIEnv* env, jobject obj) {

+static jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) {

SigninManagerAndroid* signin_manager_android =

new SigninManagerAndroid(env, obj);

return reinterpret_cast<intptr_t>(signin_manager_android);

}

-static jboolean ShouldLoadPolicyForUser(JNIEnv* env,

- jobject obj,

- jstring j_username) {

+static jboolean ShouldLoadPolicyForUser(

+ JNIEnv* env,

+ const JavaParamRef<jobject>& obj,

+ const JavaParamRef<jstring>& j_username) {

#if defined(ENABLE_CONFIGURATION_POLICY)

std::string username =

base::android::ConvertJavaStringToUTF8(env, j_username);