Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: chrome/browser/android/tab_android.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/tab/thumbnail_tab_helper_android.cc ('k') | chrome/browser/android/tab_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/tab_android.cc
diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc
index 53a53b8906c7edec1bd8883d5fe86cba8281be5e..29b558e9a4c3a5981439228776aaa24f778a7647 100644
--- a/chrome/browser/android/tab_android.cc
+++ b/chrome/browser/android/tab_android.cc
@@ -909,7 +909,7 @@ void TabAndroid::DetachOverlayContentViewCore(JNIEnv* env,
content_view_core->GetLayer()->RemoveFromParent();
}
-static void Init(JNIEnv* env, jobject obj) {
+static void Init(JNIEnv* env, const JavaParamRef<jobject>& obj) {
TRACE_EVENT0("native", "TabAndroid::Init");
// This will automatically bind to the Java object and pass ownership there.
new TabAndroid(env, obj);
@@ -920,7 +920,8 @@ bool TabAndroid::RegisterTabAndroid(JNIEnv* env) {
return RegisterNativesImpl(env);
}
-static void RecordStartupToCommitUma(JNIEnv* env, jclass jcaller) {
+static void RecordStartupToCommitUma(JNIEnv* env,
+ const JavaParamRef<jclass>& jcaller) {
// Currently it takes about 2000ms to commit a navigation if the measurement
// begins very early in the browser start. How many buckets (b) are needed to
// explore the _typical_ values with granularity 100ms and a maximum duration
« no previous file with comments | « chrome/browser/android/tab/thumbnail_tab_helper_android.cc ('k') | chrome/browser/android/tab_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698