chrome/browser/android/bookmarks/edit_bookmark_helper.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/bookmarks/edit_bookmark_helper.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/bookmarks/bookmarks_bridge.cc ('k') | chrome/browser/android/bookmarks/partner_bookmarks_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/bookmarks/edit_bookmark_helper.cc

diff --git a/chrome/browser/android/bookmarks/edit_bookmark_helper.cc b/chrome/browser/android/bookmarks/edit_bookmark_helper.cc

index c55faf7d5d70b7768623fba79c62e333a5f7964f..6b94576bae3f7472e81d1e4d9d68a5702fef1982 100644

--- a/chrome/browser/android/bookmarks/edit_bookmark_helper.cc

+++ b/chrome/browser/android/bookmarks/edit_bookmark_helper.cc

@@ -15,10 +15,10 @@

using bookmarks::BookmarkNode;

void SetPartnerBookmarkTitle(JNIEnv* env,

- jclass clazz,

- jobject jprofile,

+ const JavaParamRef<jclass>& clazz,

+ const JavaParamRef<jobject>& jprofile,

jlong bookmark_id,

- jstring new_title) {

+ const JavaParamRef<jstring>& new_title) {

PartnerBookmarksShim* partner_bookmarks_shim =

PartnerBookmarksShim::BuildForBrowserContext(

chrome::GetBrowserContextRedirectedInIncognito(