chrome/browser/android/bookmarks/partner_bookmarks_reader.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/bookmarks/partner_bookmarks_reader.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/bookmarks/edit_bookmark_helper.cc ('k') | chrome/browser/android/bottombar/contextualsearch/contextual_search_panel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/bookmarks/partner_bookmarks_reader.cc

diff --git a/chrome/browser/android/bookmarks/partner_bookmarks_reader.cc b/chrome/browser/android/bookmarks/partner_bookmarks_reader.cc

index 78941931a98d7f7a9829fbaae663ce341c5f43b1..aae7a3ebc8ac0e7af197a9f59205bc21d7fdbf51 100644

--- a/chrome/browser/android/bookmarks/partner_bookmarks_reader.cc

+++ b/chrome/browser/android/bookmarks/partner_bookmarks_reader.cc

@@ -183,7 +183,8 @@ jlong PartnerBookmarksReader::AddPartnerBookmark(JNIEnv* env,

}

// static

-static void DisablePartnerBookmarksEditing(JNIEnv* env, jclass clazz) {

+static void DisablePartnerBookmarksEditing(JNIEnv* env,

+ const JavaParamRef<jclass>& clazz) {

PartnerBookmarksShim::DisablePartnerBookmarksEditing();

}

@@ -194,7 +195,7 @@ bool PartnerBookmarksReader::RegisterPartnerBookmarksReader(JNIEnv* env) {

// ----------------------------------------------------------------

-static jlong Init(JNIEnv* env, jobject obj) {

+static jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) {

Profile* profile = ProfileManager::GetActiveUserProfile();

PartnerBookmarksShim* partner_bookmarks_shim =

PartnerBookmarksShim::BuildForBrowserContext(profile);