chrome/browser/android/bookmarks/bookmarks_bridge.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/bookmarks/bookmarks_bridge.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/banners/app_banner_manager_android.cc ('k') | chrome/browser/android/bookmarks/edit_bookmark_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/bookmarks/bookmarks_bridge.cc

diff --git a/chrome/browser/android/bookmarks/bookmarks_bridge.cc b/chrome/browser/android/bookmarks/bookmarks_bridge.cc

index 663ddc3c6a607cb26e7dc600e65a8e9cf0a53f6b..db7145acd88cb64712eb3b8a2f95cbbfc5a97920 100644

--- a/chrome/browser/android/bookmarks/bookmarks_bridge.cc

+++ b/chrome/browser/android/bookmarks/bookmarks_bridge.cc

@@ -134,13 +134,16 @@ bool BookmarksBridge::RegisterBookmarksBridge(JNIEnv* env) {

return RegisterNativesImpl(env);

}

-static jlong Init(JNIEnv* env, jobject obj, jobject j_profile) {

+static jlong Init(JNIEnv* env,

+ const JavaParamRef<jobject>& obj,

+ const JavaParamRef<jobject>& j_profile) {

BookmarksBridge* delegate = new BookmarksBridge(env, obj, j_profile);

return reinterpret_cast<intptr_t>(delegate);

}

-static jboolean IsEnhancedBookmarksFeatureEnabled(JNIEnv* env,

- jclass clazz) {

+static jboolean IsEnhancedBookmarksFeatureEnabled(

+ JNIEnv* env,

+ const JavaParamRef<jclass>& clazz) {

return enhanced_bookmarks::IsEnhancedBookmarksEnabled();

}