Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index d1588244e448a4dd680bc2b3e28e972242731fed..27d1f458df9ca7067688b74f8380bc74783d0593 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -176,29 +176,32 @@ bool AppBannerManagerAndroid::Register(JNIEnv* env) {
return RegisterNativesImpl(env);
}
-jlong Init(JNIEnv* env, jobject obj, jint icon_size) {
+jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj, jint icon_size) {
AppBannerManagerAndroid* manager =
new AppBannerManagerAndroid(env, obj, icon_size);
return reinterpret_cast<intptr_t>(manager);
}
-void SetTimeDeltaForTesting(JNIEnv* env, jclass clazz, jint days) {
+void SetTimeDeltaForTesting(JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ jint days) {
AppBannerDataFetcher::SetTimeDeltaForTesting(days);
}
-void DisableSecureSchemeCheckForTesting(JNIEnv* env, jclass clazz) {
+void DisableSecureSchemeCheckForTesting(JNIEnv* env,
+ const JavaParamRef<jclass>& clazz) {
AppBannerManager::DisableSecureSchemeCheckForTesting();
}
void SetEngagementWeights(JNIEnv* env,
- jclass clazz,
+ const JavaParamRef<jclass>& clazz,
jdouble direct_engagement,
jdouble indirect_engagement) {
AppBannerManager::SetEngagementWeights(direct_engagement,
indirect_engagement);
}
-jboolean IsEnabled(JNIEnv* env, jclass clazz) {
+jboolean IsEnabled(JNIEnv* env, const JavaParamRef<jclass>& clazz) {
return base::FieldTrialList::FindFullName("AppBanners") == "Enabled";
}
« no previous file with comments | « chrome/browser/android/appmenu/app_menu_drag_helper.cc ('k') | chrome/browser/android/bookmarks/bookmarks_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698