Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1312143003: Abstract chrome::GetChannel() through VariationsServiceClient (Closed)

Created:
5 years, 4 months ago by blundell
Modified:
5 years, 3 months ago
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, asvitkine+watch_chromium.org, rmistry1
Base URL:
https://chromium.googlesource.com/chromium/src.git@variations_service_upgrade_detector
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Abstract chrome::GetChannel() through VariationsServiceClient BUG=516678 Committed: https://crrev.com/2ef149341a8b9cbbe824bb74228244bf566986c3 Cr-Commit-Position: refs/heads/master@{#345992}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M chrome/browser/metrics/variations/chrome_variations_service_client.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metrics/variations/chrome_variations_service_client.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M components/variations.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M components/variations/service/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A + components/variations/service/DEPS View 1 2 3 4 5 1 chunk +1 line, -3 lines 0 comments Download
M components/variations/service/variations_service_client.h View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1306893007 Patch 1

Dependent Patchsets:

Issue 1309843005 Patch 1
Issue 1309843005 Patch 20001
Issue 1309843005 Patch 40001

Messages

Total messages: 10 (2 generated)
blundell
5 years, 4 months ago (2015-08-25 14:42:32 UTC) #2
Alexei Svitkine (slow)
Will wait till you fix the red bots.
5 years, 4 months ago (2015-08-25 14:57:09 UTC) #3
blundell
5 years, 3 months ago (2015-08-27 13:47:40 UTC) #4
blundell
On 2015/08/27 13:47:40, blundell wrote: (red bots are fixed now)
5 years, 3 months ago (2015-08-27 15:36:18 UTC) #5
Alexei Svitkine (slow)
lgtm
5 years, 3 months ago (2015-08-27 15:55:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312143003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312143003/100001
5 years, 3 months ago (2015-08-27 21:14:36 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 3 months ago (2015-08-27 21:19:54 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 21:20:54 UTC) #10
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/2ef149341a8b9cbbe824bb74228244bf566986c3
Cr-Commit-Position: refs/heads/master@{#345992}

Powered by Google App Engine
This is Rietveld 408576698