Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1306893007: //components/variations: Create separate target for VariationsService (Closed)

Created:
5 years, 3 months ago by blundell
Modified:
5 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

//components/variations: Create separate target for VariationsService When VariationsService is componentized, it will bring in dependencies on //net and //ui, which are unwanted in the //components/variations target. In particular, Cronet depends on //components/variations and cannot depend on //net. This CL creates //components/variations/service, which currently holds variations_service_client.h and will hold variations_service.* once it is componentized. BUG=516678 TBR=brettw Committed: https://crrev.com/b50ad70d3243979e42fe667a9b9e26bd1910eba9 Cr-Commit-Position: refs/heads/master@{#345905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -66 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metrics/variations/chrome_variations_service_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/variations/variations_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/variations.gypi View 2 chunks +16 lines, -1 line 0 comments Download
M components/variations/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
A + components/variations/service/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
A + components/variations/service/variations_service_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
D components/variations/variations_service_client.h View 1 chunk +0 lines, -56 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
blundell
5 years, 3 months ago (2015-08-27 13:47:54 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 3 months ago (2015-08-27 15:11:23 UTC) #3
blundell
TBR=brettw for the trival change to //chrome/browser/BUILD.gn
5 years, 3 months ago (2015-08-27 15:25:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306893007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306893007/1
5 years, 3 months ago (2015-08-27 15:26:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 17:08:36 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 17:09:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b50ad70d3243979e42fe667a9b9e26bd1910eba9
Cr-Commit-Position: refs/heads/master@{#345905}

Powered by Google App Engine
This is Rietveld 408576698