chrome/browser/metrics/variations/chrome_variations_service_client.cc - Issue 1312143003: Abstract chrome::GetChannel() through VariationsServiceClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/variations/chrome_variations_service_client.cc

Issue 1312143003: Abstract chrome::GetChannel() through VariationsServiceClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@variations_service_upgrade_detector

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/variations/chrome_variations_service_client.h ('k') | chrome/browser/metrics/variations/variations_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/variations/chrome_variations_service_client.cc

diff --git a/chrome/browser/metrics/variations/chrome_variations_service_client.cc b/chrome/browser/metrics/variations/chrome_variations_service_client.cc

index 93f383f5fbf81a1dffacdc4f8d6d38420f0ea49e..cbc2b789e18805cc2af235c0e3cdec89b4b49945 100644

--- a/chrome/browser/metrics/variations/chrome_variations_service_client.cc

+++ b/chrome/browser/metrics/variations/chrome_variations_service_client.cc

@@ -6,6 +6,7 @@

#include "base/bind.h"

#include "chrome/browser/browser_process.h"

+#include "chrome/common/channel_info.h"

#include "components/version_info/version_info.h"

#include "content/public/browser/browser_thread.h"

@@ -59,6 +60,10 @@ ChromeVariationsServiceClient::GetNetworkTimeTracker() {

return g_browser_process->network_time_tracker();

}

+version_info::Channel ChromeVariationsServiceClient::GetChannel() {

+ return chrome::GetChannel();

void ChromeVariationsServiceClient::OnInitialStartup() {

#if defined(OS_WIN)

StartGoogleUpdateRegistrySync();