Reland "Make sure that memory reducer makes progress in incremental marking""

Reland "Make sure that memory reducer makes progress in incremental marking""

This reverts commit b06a6a891cc762835577bb856f8c5e8f0bf8ab31.

BUG=chromium:519319, chromium:515873
LOG=NO

Committed: https://crrev.com/69bb3e1f1fcf449c95619d9dd1baa883c7cb51ad
Cr-Commit-Position: refs/heads/master@{#30569}

[ulan_google, 2015-09-03 14:33:12]

ulan@google.com changed reviewers:
+ mlippautz@chromium.org, ulan@google.com

[ulan_google, 2015-09-03 14:33:12]

PTAL. The patch set 1 contains the original CL + DCHECK in incremenal-marking +
regression test.

The patch set 2 contains the actual fix.

[Michael Lippautz, 2015-09-03 15:01:49]

lgtm, thanks for fixing this immediately :)

https://codereview.chromium.org/1311993003/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1311993003/diff/60001/src/heap/heap.h#newcode843
src/heap/heap.h:843: void FinalizeIncrementalMarkingIfComplete(const char*
comment);
nit: There's a section for incremental marking around line ~1277.

https://codereview.chromium.org/1311993003/diff/60001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://codereview.chromium.org/1311993003/diff/60001/test/cctest/test-heap.c...
test/cctest/test-heap.cc:6692: }
nit: Please add a comment stating that we are concurrently sweeping and depend
on the timing here.

[ulan_google, 2015-09-03 15:07:01]

Thanks!

https://codereview.chromium.org/1311993003/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1311993003/diff/60001/src/heap/heap.h#newcode843
src/heap/heap.h:843: void FinalizeIncrementalMarkingIfComplete(const char*
comment);
On 2015/09/03 15:01:49, Michael Lippautz wrote:
> nit: There's a section for incremental marking around line ~1277.

Done.

https://codereview.chromium.org/1311993003/diff/60001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://codereview.chromium.org/1311993003/diff/60001/test/cctest/test-heap.c...
test/cctest/test-heap.cc:6692: }
On 2015/09/03 15:01:49, Michael Lippautz wrote:
> nit: Please add a comment stating that we are concurrently sweeping and depend
> on the timing here.

Done.

[ulan_google, 2015-09-03 15:07:12]

The CQ bit was checked by ulan@google.com

[ulan_google, 2015-09-03 15:07:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/1311993003/#ps80001
(title: "Address comments")

[commit-bot: I haz the power, 2015-09-03 15:07:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311993003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311993003/80001

[commit-bot: I haz the power, 2015-09-03 15:34:42]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-03 15:34:57]

Patchset 5 (id:??) landed as
https://crrev.com/69bb3e1f1fcf449c95619d9dd1baa883c7cb51ad
Cr-Commit-Position: refs/heads/master@{#30569}