src/heap/incremental-marking.cc - Issue 1311993003: Reland "Make sure that memory reducer makes progress in incremental marking""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/incremental-marking.cc

Issue 1311993003: Reland "Make sure that memory reducer makes progress in incremental marking"" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/incremental-marking.cc

diff --git a/src/heap/incremental-marking.cc b/src/heap/incremental-marking.cc

index 009f4ca284236aa990106552e159f0d151007dde..b420cb728c0a401c5c4a93187ddce12b6cc42c38 100644

--- a/src/heap/incremental-marking.cc

+++ b/src/heap/incremental-marking.cc

@@ -541,6 +541,7 @@ void IncrementalMarking::StartMarking() {

void IncrementalMarking::MarkObjectGroups() {

DCHECK(FLAG_overapproximate_weak_closure);

DCHECK(!weak_closure_was_overapproximated_);

+ DCHECK(IsMarking());

int old_marking_deque_top =

heap_->mark_compact_collector()->marking_deque()->top();

« no previous file with comments | « src/heap/heap.cc ('k') | src/heap/memory-reducer.cc » ('j') | no next file with comments »