Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311803002: Dart: Removes dartzip (Closed)

Created:
5 years, 4 months ago by zra
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart: Removes dartzip This change removes support for the dartzip format from the Dart content handler and the build rules. It also removes the upload of apptest.dartzip. In a subsequent CL, I'll move the apptest library under //mojo/public/dart. BUG= R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1c77edf950ee4f2e3f6c5bfa39ebe52d5404c778

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Readme fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -1055 lines) Patch
M examples/dart/device_info/BUILD.gn View 2 chunks +2 lines, -19 lines 0 comments Download
M examples/dart/hello_world/hello/BUILD.gn View 2 chunks +2 lines, -19 lines 0 comments Download
M examples/dart/hello_world/world/BUILD.gn View 2 chunks +2 lines, -27 lines 0 comments Download
M examples/dart/netcat/BUILD.gn View 2 chunks +2 lines, -22 lines 0 comments Download
M examples/dart/traced_application/BUILD.gn View 2 chunks +2 lines, -20 lines 0 comments Download
M examples/dart/wget/BUILD.gn View 2 chunks +2 lines, -20 lines 0 comments Download
M mojo/common/dart/BUILD.gn View 2 chunks +1 line, -20 lines 0 comments Download
M mojo/dart/apptest/BUILD.gn View 2 chunks +1 line, -19 lines 0 comments Download
M mojo/dart/apptest/lib/apptest.dart View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/dart/http_load_test/BUILD.gn View 2 chunks +2 lines, -21 lines 0 comments Download
M mojo/dart/mojo_services/BUILD.gn View 2 chunks +1 line, -17 lines 0 comments Download
M mojo/dart/observatory_test/BUILD.gn View 2 chunks +2 lines, -18 lines 0 comments Download
M mojo/dart/observatory_tester/runner.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/dart/BUILD.gn View 2 chunks +1 line, -23 lines 0 comments Download
M mojo/public/dart/README.md View 1 2 3 chunks +50 lines, -48 lines 0 comments Download
M mojo/public/dart/rules.gni View 2 chunks +1 line, -210 lines 0 comments Download
M mojo/public/tools/BUILD.gn View 1 chunk +0 lines, -15 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 3 chunks +0 lines, -46 lines 0 comments Download
M mojo/public/tools/dart_analyze.py View 5 chunks +3 lines, -49 lines 0 comments Download
D mojo/public/tools/dart_list_packages_contents.py View 1 chunk +0 lines, -42 lines 0 comments Download
D mojo/public/tools/dart_package.py View 1 chunk +0 lines, -172 lines 0 comments Download
D mojo/public/tools/download_archiecture_independent_frameworks.py View 1 chunk +0 lines, -82 lines 0 comments Download
M mojo/tools/data/apptests View 1 chunk +1 line, -5 lines 0 comments Download
M mojo/tools/upload_binaries.py View 5 chunks +1 line, -28 lines 0 comments Download
M services/dart/content_handler_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/dart/dart_app.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M services/dart/dart_apptests/BUILD.gn View 2 chunks +1 line, -34 lines 0 comments Download
M services/dart/dart_apptests/lib/src/echo_apptests.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M services/dart/dart_apptests/lib/src/pingpong_apptests.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M services/dart/test/echo/BUILD.gn View 2 chunks +2 lines, -19 lines 0 comments Download
M services/dart/test/pingpong/BUILD.gn View 2 chunks +2 lines, -19 lines 0 comments Download
M services/dart/test/pingpong_target/BUILD.gn View 2 chunks +2 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
zra
5 years, 4 months ago (2015-08-24 17:33:51 UTC) #2
Cutch
lgtm
5 years, 4 months ago (2015-08-24 17:40:40 UTC) #3
zra
5 years, 4 months ago (2015-08-24 21:31:42 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:30001) manually as
1c77edf950ee4f2e3f6c5bfa39ebe52d5404c778 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698