Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: mojo/public/dart/rules.gni

Issue 1311803002: Dart: Removes dartzip (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Readme fixes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/dart/README.md ('k') | mojo/public/tools/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/dart/rules.gni
diff --git a/mojo/public/dart/rules.gni b/mojo/public/dart/rules.gni
index ada9e4b64548d7cc4744867b90d19e567055aec4..f8c7ccb7a4c43dd1a6fb942644c75d46fe2423c4 100644
--- a/mojo/public/dart/rules.gni
+++ b/mojo/public/dart/rules.gni
@@ -3,11 +3,7 @@
# found in the LICENSE file.
# This file has rules for making Dart packages and Dart-based Mojo applications.
-#
-# Entrypoint rules are:
-# - dart_pkg
-# - dartzip_package
-# - dartzip_packaged_application
+# The entrypoint is the dart_pkg rule.
import("../mojo.gni")
import("//build/module_args/mojo.gni")
@@ -411,208 +407,3 @@ template("dart_pkg") {
}
}
}
-
-# Creates a dartzip package.
-template("dartzip_package") {
- package_target_name = "$target_name"
- package_output = "$target_out_dir/$target_name.dartzip"
-
- if (defined(invoker.uses_pub) && invoker.uses_pub) {
- # Repackage all dependencies pulled in via "pub get" in a dartzip file.
- action("${package_target_name}_repackage") {
- target_dir = get_label_info(":$target_name", "dir")
- script = rebase_path("mojo/public/tools/gn/zip.py", ".", mojo_sdk_root)
-
- package_name = "$package_target_name"
- if (defined(invoker.package_name_override)) {
- package_name = invoker.package_name_override
- }
-
- # Get a list of the files in packages/ as inputs.
- list_packages_contents_script =
- rebase_path("mojo/public/tools/dart_list_packages_contents.py",
- ".",
- mojo_sdk_root)
- rebase_target_dir = rebase_path(target_dir, root_build_dir)
- inputs = exec_script(list_packages_contents_script,
- [
- "--target-directory",
- rebase_target_dir,
- "--package-name",
- package_name,
- ],
- "list lines",
- [ target_dir + "/pubspec.lock" ])
-
- # Zip up all the pulled-in files relative to their location in the
- # packages dir.
- output = "$target_out_dir/$target_name.dartzip"
- outputs = [
- output,
- ]
- rebase_base_dir = rebase_target_dir
- rebase_inputs = rebase_path(inputs, root_build_dir)
- rebase_output = rebase_path(output, root_build_dir)
- args = [
- "--base-dir=$rebase_base_dir",
- "--inputs=$rebase_inputs",
- "--output=$rebase_output",
- ]
- }
- }
-
- action("${package_target_name}_package") {
- script =
- rebase_path("mojo/public/tools/dart_package.py", ".", mojo_sdk_root)
-
- inputs = invoker.sources
-
- deps = []
- zip_inputs = []
-
- if (defined(invoker.uses_pub) && invoker.uses_pub) {
- deps += [ ":${package_target_name}_repackage" ]
- }
-
- if (defined(invoker.deps)) {
- deps += invoker.deps
- foreach(d, deps) {
- dep_name = get_label_info(d, "name")
- dep_target_out_dir = get_label_info(d, "target_out_dir")
- zip_inputs += [ "$dep_target_out_dir/$dep_name.dartzip" ]
- }
- }
-
- if (defined(invoker.datadeps)) {
- datadeps = invoker.datadeps
- }
-
- output = package_output
- outputs = [
- output,
- ]
-
- rebase_base_dir =
- rebase_path(get_label_info(":$package_target_name", "dir"),
- root_build_dir)
- if (defined(invoker.base_dir)) {
- rebase_base_dir = invoker.base_dir
- }
- rebase_inputs = rebase_path(inputs, root_build_dir)
- rebase_zip_inputs = rebase_path(zip_inputs, root_build_dir)
- rebase_output = rebase_path(output, root_build_dir)
-
- args = [
- "--base-dir=$rebase_base_dir",
- "--inputs=$rebase_inputs",
- "--zip-inputs=$rebase_zip_inputs",
- "--output=$rebase_output",
- ]
- }
-
- action(target_name) {
- script =
- rebase_path("mojo/public/tools/dart_analyze.py", ".", mojo_sdk_root)
-
- sources = [
- package_output,
- ]
-
- args = [
- "--dart-sdk",
- rebase_path(dart_sdk_root),
- "--dartzip-file",
- rebase_path(package_output),
- "--stamp-file",
- rebase_path("$target_gen_dir/${package_target_name}_analyze.stamp"),
- "--no-hints",
- ]
-
- public_deps = [
- ":${package_target_name}_package",
- ]
- if (defined(invoker.deps)) {
- deps = invoker.deps
- }
-
- if (defined(invoker.datadeps)) {
- datadeps = invoker.datadeps
- }
-
- outputs = [
- "$target_gen_dir/${package_target_name}_analyze.stamp",
- ]
- }
-}
-
-# Use this template to generate a .mojo dart application. One of the source
-# files should be named main.dart and contain a main function as the
-# entry point. Dependencies of dart_packaged_application targets should be
-# either mojom targets (and specified using the mojom_deps variable) or
-# dartzip_package targets.
-template("dartzip_packaged_application") {
- package_name = "${target_name}_package"
- package_output = "$target_out_dir/$package_name.dartzip"
-
- if (defined(invoker.output_name)) {
- mojo_output = "$root_out_dir/" + invoker.output_name + ".mojo"
- } else {
- mojo_output = "$root_out_dir/" + target_name + ".mojo"
- }
-
- dartzip_package(package_name) {
- sources = invoker.sources
- if (defined(invoker.deps)) {
- deps = invoker.deps
- }
- if (defined(invoker.uses_pub)) {
- uses_pub = invoker.uses_pub
- }
- if (defined(invoker.mojom_deps)) {
- mojom_deps = invoker.mojom_deps
- }
- if (defined(invoker.datadeps)) {
- datadeps = invoker.datadeps
- }
- }
-
- action(target_name) {
- script = rebase_path("mojo/public/tools/prepend.py", ".", mojo_sdk_root)
-
- input = package_output
- inputs = [
- input,
- ]
-
- output = mojo_output
- outputs = [
- output,
- ]
-
- deps = [
- ":$package_name",
- ]
- if (defined(invoker.deps)) {
- deps += invoker.deps
- }
- if (defined(invoker.mojom_deps)) {
- deps += invoker.mojom_deps
- }
- if (defined(invoker.datadeps)) {
- datadeps = invoker.datadeps
- }
-
- line = "#!mojo mojo:dart_content_handler"
- if (is_debug || (defined(invoker.strict) && invoker.strict == true)) {
- line = "#!mojo mojo:dart_content_handler?strict=true"
- }
-
- rebase_input = rebase_path(input, root_build_dir)
- rebase_output = rebase_path(output, root_build_dir)
- args = [
- "--input=$rebase_input",
- "--output=$rebase_output",
- "--line=$line",
- ]
- }
-}
« no previous file with comments | « mojo/public/dart/README.md ('k') | mojo/public/tools/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698