Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: mojo/public/tools/bindings/mojom.gni

Issue 1311803002: Dart: Removes dartzip (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Readme fixes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/tools/BUILD.gn ('k') | mojo/public/tools/dart_analyze.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/tools/bindings/mojom.gni
diff --git a/mojo/public/tools/bindings/mojom.gni b/mojo/public/tools/bindings/mojom.gni
index f990b2105a7ffa575444b98e77556eafed507b68..0c0f294c5c5d5ad5ca8a7b08e48a52dae8f155a2 100644
--- a/mojo/public/tools/bindings/mojom.gni
+++ b/mojo/public/tools/bindings/mojom.gni
@@ -149,7 +149,6 @@ template("mojom") {
generator_java_outputs =
[ "{{source_gen_dir}}/{{source_name_part}}.mojom.srcjar" ]
}
- generator_dart_zip_output = "$target_out_dir/$target_name.dartzip"
generator_python_zip_output = "$target_out_dir/${target_name}_python.pyzip"
rebased_mojo_sdk_public_deps = []
@@ -234,7 +233,6 @@ template("mojom") {
if (defined(invoker.deps)) {
deps += invoker.deps
}
- data_deps = [ ":${target_name}_dart" ]
if (defined(invoker.mojo_sdk_deps)) {
foreach(sdk_dep, invoker.mojo_sdk_deps) {
# Check that the SDK dep was not mistakenly given as an absolute path.
@@ -309,50 +307,6 @@ template("mojom") {
}
}
- action("${target_name}_dart") {
- script = rebase_path("mojo/public/tools/gn/zip.py", ".", mojo_root)
-
- deps = []
- zip_inputs = []
-
- if (defined(invoker.sources)) {
- inputs = process_file_template(invoker.sources, generator_dart_outputs)
- deps += [ ":$generator_target_name" ]
- }
-
- foreach(d, all_deps) {
- # Resolve the name, so that a target //mojo/something becomes
- # //mojo/something:something and we can append "_dart" to get the dart
- # dependency name.
- full_name = get_label_info(d, "label_no_toolchain")
- dep_name = get_label_info(d, "name")
- dep_target_out_dir = get_label_info(d, "target_out_dir")
- deps += [ "${full_name}_dart" ]
- zip_inputs += [ "$dep_target_out_dir/$dep_name.dartzip" ]
- }
-
- output = generator_dart_zip_output
- outputs = [
- output,
- ]
-
- rebase_import_from =
- rebase_path("$root_build_dir/gen/dart-gen", root_build_dir)
- if (defined(invoker.sources)) {
- rebase_inputs = rebase_path(inputs, root_build_dir)
- }
- rebase_zip_inputs = rebase_path(zip_inputs, root_build_dir)
- rebase_output = rebase_path(output, root_build_dir)
- args = [
- "--base-dir=$rebase_import_from",
- "--zip-inputs=$rebase_zip_inputs",
- "--output=$rebase_output",
- ]
- if (defined(invoker.sources)) {
- args += [ "--link-inputs=$rebase_inputs" ]
- }
- }
-
if (defined(invoker.sources)) {
# The generated C++ source files. The main reason to introduce this target
# is so that mojo/public/cpp/bindings can depend on mojom interfaces without
« no previous file with comments | « mojo/public/tools/BUILD.gn ('k') | mojo/public/tools/dart_analyze.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698