Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1311543005: Show hosted app requests to extensions (Closed)

Created:
5 years, 3 months ago by robwu
Modified:
5 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show hosted app requests to extensions BUG=526413 TEST=browser_tests --gtest_filter=ExtensionWebRequestApiTest.HostedAppRequest Committed: https://crrev.com/1db473b2e3b66646a7470e543540a44e854cd8f7 Cr-Commit-Position: refs/heads/master@{#347756}

Patch Set 1 #

Total comments: 9

Patch Set 2 : Use extension_info_map-extensions() #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -7 lines) Patch
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 2 chunks +31 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/webrequest_hosted_app/background.js View 1 chunk +4 lines, -3 lines 0 comments Download
A chrome/test/data/extensions/api_test/webrequest_hosted_app/index.html View 1 chunk +12 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/webrequest_hosted_app/manifest.json View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 1 1 chunk +14 lines, -1 line 1 comment Download

Messages

Total messages: 10 (2 generated)
robwu
https://codereview.chromium.org/1311543005/diff/1/extensions/browser/api/web_request/web_request_api.cc File extensions/browser/api/web_request/web_request_api.cc (right): https://codereview.chromium.org/1311543005/diff/1/extensions/browser/api/web_request/web_request_api.cc#newcode171 extensions/browser/api/web_request/web_request_api.cc:171: if (browser_context) { I'm not sure whether it is ...
5 years, 3 months ago (2015-09-05 17:29:10 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/1311543005/diff/1/chrome/test/data/extensions/api_test/webrequest_hosted_app/background.js File chrome/test/data/extensions/api_test/webrequest_hosted_app/background.js (right): https://codereview.chromium.org/1311543005/diff/1/chrome/test/data/extensions/api_test/webrequest_hosted_app/background.js#newcode7 chrome/test/data/extensions/api_test/webrequest_hosted_app/background.js:7: urls: ['*://*/*webrequest_hosted_app*'] I don't know the webrequest API very ...
5 years, 3 months ago (2015-09-08 16:09:21 UTC) #3
robwu
https://codereview.chromium.org/1311543005/diff/1/chrome/test/data/extensions/api_test/webrequest_hosted_app/background.js File chrome/test/data/extensions/api_test/webrequest_hosted_app/background.js (right): https://codereview.chromium.org/1311543005/diff/1/chrome/test/data/extensions/api_test/webrequest_hosted_app/background.js#newcode7 chrome/test/data/extensions/api_test/webrequest_hosted_app/background.js:7: urls: ['*://*/*webrequest_hosted_app*'] On 2015/09/08 16:09:20, kalman wrote: > I ...
5 years, 3 months ago (2015-09-08 17:19:48 UTC) #4
not at google - send to devlin
lgtm
5 years, 3 months ago (2015-09-08 17:32:06 UTC) #5
not at google - send to devlin
https://codereview.chromium.org/1311543005/diff/20001/extensions/browser/api/web_request/web_request_api.cc File extensions/browser/api/web_request/web_request_api.cc (right): https://codereview.chromium.org/1311543005/diff/20001/extensions/browser/api/web_request/web_request_api.cc#newcode162 extensions/browser/api/web_request/web_request_api.cc:162: const std::set<std::string> extension_ids = btw for clarity between "extension ...
5 years, 3 months ago (2015-09-08 17:33:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311543005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311543005/20001
5 years, 3 months ago (2015-09-08 17:34:28 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-08 18:57:42 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 18:58:08 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1db473b2e3b66646a7470e543540a44e854cd8f7
Cr-Commit-Position: refs/heads/master@{#347756}

Powered by Google App Engine
This is Rietveld 408576698