chrome/test/data/extensions/api_test/webrequest_hosted_app/index.html - Issue 1311543005: Show hosted app requests to extensions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/webrequest_hosted_app/index.html

Issue 1311543005: Show hosted app requests to extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!--

	2 * Copyright 2015 The Chromium Authors. All rights reserved. Use of this

	3 * source code is governed by a BSD-style license that can be found in the

	4 * LICENSE file.

	5 -->

	6 <script>

	7 console.assert(chrome.app.isInstalled, 'This page should be a hosted app.');

	8

	9 fetch('./index.html').catch(function() {
	not at google - send to devlin 2015/09/08 16:09:20 fetch? this doesn't rely on my recent patch, right fetch? this doesn't rely on my recent patch, right? https://chromium.googlesource.com/chromium/src/+/30a92f969db1ea52cc1688378341... seems probably not because this is executing inside a webpage, but do remember we're going to be merging this into M45, so the tests need to pass there as well. robwu 2015/09/08 17:19:48 fetch works fine because this page is served at ht Show quoted text On 2015/09/08 16:09:20, kalman wrote: > fetch? this doesn't rely on my recent patch, right? > > https://chromium.googlesource.com/chromium/src/+/30a92f969db1ea52cc1688378341... > > seems probably not because this is executing inside a webpage, but do remember > we're going to be merging this into M45, so the tests need to pass there as > well. fetch works fine because this page is served at http://localhost:PORT/ (note also that hosted apps only make sense for http(s)).
	10 console.error('fetch unexpectedly failed!');

	11 });

	12 </script>

OLD	NEW