Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 1311043010: Improve getFallbackFamily() for Unified Han Ideographs on Windows (Closed)

Created:
5 years, 3 months ago by kojii
Modified:
5 years, 3 months ago
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Improve getFallbackFamily() for Unified Han Ideographs on Windows This patch improves getFallbackFamily() to find fallback fonts from a character code for a generic family when the specified character is Unified Han Ideographs. In this case, Blink uses ICU default locale. This patch improves: 1. Japanese and Korean can disambiguate by languages. Comparing fullName can fail on, for instance, English OS with display language set to these languages. 2. zh-HK maps to USCRIPT_TRADITIONAL_HAN, same as what localeToScriptCodeForFontSelection() in LocaleToScriptMapping does. BUG=509680 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201863

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Moved mapping logic to LocaleToScriptMapping #

Patch Set 4 : Move mapping logic back to FontFallbackWin #

Patch Set 5 : Move mapping logic back to FontFallbackWin #

Total comments: 1

Patch Set 6 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -13 lines) Patch
M Source/platform/blink_platform.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/fonts/win/FontFallbackWin.h View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M Source/platform/fonts/win/FontFallbackWin.cpp View 1 2 3 4 5 2 chunks +25 lines, -13 lines 0 comments Download
A Source/platform/fonts/win/FontFallbackWinTest.cpp View 1 2 3 4 5 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
kojii
PTAL.
5 years, 3 months ago (2015-09-03 15:09:18 UTC) #3
kojii
On 2015/09/03 15:09:18, kojii wrote: > PTAL. A bit of clarification: I moved the logic ...
5 years, 3 months ago (2015-09-04 01:15:55 UTC) #4
drott
Thanks for working on improving this. I'd suggest a bit more verbose testing to document ...
5 years, 3 months ago (2015-09-04 08:26:15 UTC) #5
kojii
On 2015/09/04 08:26:15, drott wrote: > Thanks for working on improving this. I'd suggest a ...
5 years, 3 months ago (2015-09-04 16:35:18 UTC) #6
drott
LGTM, thanks for adding the tests!
5 years, 3 months ago (2015-09-07 06:36:43 UTC) #8
kojii
Thanks for your prompt review!
5 years, 3 months ago (2015-09-07 06:37:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311043010/110001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311043010/110001
5 years, 3 months ago (2015-09-07 06:37:59 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:110001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201863
5 years, 3 months ago (2015-09-07 07:57:29 UTC) #12
drott
5 years, 3 months ago (2015-09-07 08:37:35 UTC) #13
Message was sent while issue was closed.
> Ideally I'd like to unify these logic across platforms, but doing so looks a
bit
> complex as the code path to reach there is quite different as of today.

PS: That'd be great :-) I also need fallback to get unified for the work on
shaper driven run segmentation.

Powered by Google App Engine
This is Rietveld 408576698