Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1310963002: [Android] Additional forward_variables_from conversions. (Closed)

Created:
5 years, 4 months ago by jbudorick
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Additional forward_variables_from conversions. Following up on https://codereview.chromium.org/1258303003#msg10 BUG= Committed: https://crrev.com/e69a6fad667c8ed249a13fc7d1b397473e311fd0 Cr-Commit-Position: refs/heads/master@{#345433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -36 lines) Patch
M build/config/android/rules.gni View 16 chunks +14 lines, -36 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbudorick
5 years, 4 months ago (2015-08-23 01:30:58 UTC) #2
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-25 19:33:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310963002/1
5 years, 4 months ago (2015-08-25 20:38:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-25 21:07:16 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 21:08:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e69a6fad667c8ed249a13fc7d1b397473e311fd0
Cr-Commit-Position: refs/heads/master@{#345433}

Powered by Google App Engine
This is Rietveld 408576698