Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1258303003: [Android] Suppress findbugs stderr output. (Closed)

Created:
5 years, 4 months ago by jbudorick
Modified:
5 years, 4 months ago
Reviewers:
cjhopman, Dirk Pranke
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Suppress findbugs stderr output. BUG=514342 Committed: https://crrev.com/5194d46039a269294d3e5bf7a1c827303521d79d Cr-Commit-Position: refs/heads/master@{#344992}

Patch Set 1 #

Patch Set 2 : rebase + reenable findbugs_verbose on GN #

Total comments: 2

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -30 lines) Patch
D build/android/findbugs_action.gypi View 1 chunk +0 lines, -22 lines 0 comments Download
M build/android/findbugs_diff.py View 3 chunks +6 lines, -0 lines 0 comments Download
M build/android/pylib/cmd_helper.py View 1 1 chunk +23 lines, -5 lines 0 comments Download
M build/android/pylib/utils/findbugs.py View 1 chunk +6 lines, -2 lines 0 comments Download
M build/config/android/config.gni View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 2 2 chunks +10 lines, -1 line 0 comments Download
M build/config/android/rules.gni View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M build/java.gypi View 2 chunks +12 lines, -0 lines 0 comments Download
M build/java_apk.gypi View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
jbudorick
5 years, 4 months ago (2015-07-28 21:40:34 UTC) #2
jbudorick
ping
5 years, 4 months ago (2015-08-04 15:24:08 UTC) #3
cjhopman
It's always the case that findbugs stderr output isn't helpful?
5 years, 4 months ago (2015-08-04 23:09:28 UTC) #4
jbudorick
On 2015/08/04 at 23:09:28, cjhopman wrote: > It's always the case that findbugs stderr output ...
5 years, 4 months ago (2015-08-04 23:16:02 UTC) #5
jbudorick
+dpranke since cjhopman is gone
5 years, 4 months ago (2015-08-17 14:24:48 UTC) #7
Dirk Pranke
lgtm, though I'm no findbugs expert. https://codereview.chromium.org/1258303003/diff/20001/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/1258303003/diff/20001/build/config/android/rules.gni#newcode1597 build/config/android/rules.gni:1597: } this can ...
5 years, 4 months ago (2015-08-17 19:25:02 UTC) #8
jbudorick
https://codereview.chromium.org/1258303003/diff/20001/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/1258303003/diff/20001/build/config/android/rules.gni#newcode1597 build/config/android/rules.gni:1597: } On 2015/08/17 at 19:25:02, Dirk Pranke wrote: > ...
5 years, 4 months ago (2015-08-22 22:45:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258303003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258303003/40001
5 years, 4 months ago (2015-08-22 22:45:25 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-22 23:33:26 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-22 23:34:34 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5194d46039a269294d3e5bf7a1c827303521d79d
Cr-Commit-Position: refs/heads/master@{#344992}

Powered by Google App Engine
This is Rietveld 408576698