Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1310273006: Devtools: convert pair of booleans in setInspectModeEnabled into enum parameter (Closed)

Created:
5 years, 3 months ago by sergeyv
Modified:
5 years, 3 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: convert pair of booleans in setInspectModeEnabled into enum parameter BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201447

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -39 lines) Patch
M LayoutTests/inspector-protocol/dom/dom-setInspectModeEnabled.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/inspect-mode-shadow-text.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/inspect-pointer-events-none.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/inspect-pseudo-element.html View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 1 chunk +16 lines, -4 lines 0 comments Download
M Source/devtools/front_end/components/InspectElementModeController.js View 1 2 chunks +12 lines, -3 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 1 2 chunks +5 lines, -6 lines 0 comments Download
M Source/devtools/front_end/screencast/ScreencastView.js View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/devtools/front_end/sdk/DOMModel.js View 3 chunks +9 lines, -12 lines 0 comments Download
M Source/devtools/protocol.json View 1 3 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sergeyv
5 years, 3 months ago (2015-08-29 01:19:59 UTC) #2
dgozman
lgtm with comments https://codereview.chromium.org/1310273006/diff/1/Source/devtools/front_end/components/InspectElementModeController.js File Source/devtools/front_end/components/InspectElementModeController.js (right): https://codereview.chromium.org/1310273006/diff/1/Source/devtools/front_end/components/InspectElementModeController.js#newcode92 Source/devtools/front_end/components/InspectElementModeController.js:92: domModel.setInspectMode(WebInspector.moduleSetting("showUAShadowDOM").get() ? DOMAgent.InspectMode.SearchForUAShadowDOM : DOMAgent.InspectMode.SearchForNormal); Where ...
5 years, 3 months ago (2015-08-29 01:36:40 UTC) #3
sergeyv
https://codereview.chromium.org/1310273006/diff/1/Source/devtools/front_end/components/InspectElementModeController.js File Source/devtools/front_end/components/InspectElementModeController.js (right): https://codereview.chromium.org/1310273006/diff/1/Source/devtools/front_end/components/InspectElementModeController.js#newcode92 Source/devtools/front_end/components/InspectElementModeController.js:92: domModel.setInspectMode(WebInspector.moduleSetting("showUAShadowDOM").get() ? DOMAgent.InspectMode.SearchForUAShadowDOM : DOMAgent.InspectMode.SearchForNormal); On 2015/08/29 01:36:40, dgozman ...
5 years, 3 months ago (2015-08-29 02:03:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310273006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310273006/20001
5 years, 3 months ago (2015-08-29 02:03:59 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-29 03:20:11 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201447

Powered by Google App Engine
This is Rietveld 408576698