Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: Source/devtools/front_end/screencast/ScreencastView.js

Issue 1310273006: Devtools: convert pair of booleans in setInspectModeEnabled into enum parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/elements/ElementsPanel.js ('k') | Source/devtools/front_end/sdk/DOMModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/screencast/ScreencastView.js
diff --git a/Source/devtools/front_end/screencast/ScreencastView.js b/Source/devtools/front_end/screencast/ScreencastView.js
index 62084c2bbe672d8e75d980fa8a3bf81be2256cbc..cb506fac5dc1dade2a986e66e72a687287b07204 100644
--- a/Source/devtools/front_end/screencast/ScreencastView.js
+++ b/Source/devtools/front_end/screencast/ScreencastView.js
@@ -678,14 +678,13 @@ WebInspector.ScreencastView.prototype = {
/**
* @override
- * @param {boolean} enabled
- * @param {boolean} inspectUAShadowDOM
+ * @param {!DOMAgent.InspectMode} mode
* @param {!DOMAgent.HighlightConfig} config
* @param {function(?Protocol.Error)=} callback
*/
- setInspectModeEnabled: function(enabled, inspectUAShadowDOM, config, callback)
+ setInspectMode: function(mode, config, callback)
{
- this._inspectModeConfig = enabled ? config : null;
+ this._inspectModeConfig = mode !== DOMAgent.InspectMode.None ? config : null;
if (callback)
callback(null);
},
« no previous file with comments | « Source/devtools/front_end/elements/ElementsPanel.js ('k') | Source/devtools/front_end/sdk/DOMModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698