Source/core/inspector/InspectorDOMAgent.h - Issue 1310273006: Devtools: convert pair of booleans in setInspectModeEnabled into enum parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorDOMAgent.h

Issue 1310273006: Devtools: convert pair of booleans in setInspectModeEnabled into enum parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/inspector/InspectorDOMAgent.h

diff --git a/Source/core/inspector/InspectorDOMAgent.h b/Source/core/inspector/InspectorDOMAgent.h

index b2a2bcfb271985872668e1b00f423759b39bc6c5..347ca465a5b151cf76711156e2c0647687bedeb5 100644

--- a/Source/core/inspector/InspectorDOMAgent.h

+++ b/Source/core/inspector/InspectorDOMAgent.h

@@ -123,7 +123,7 @@ public:

void discardSearchResults(ErrorString*, const String& searchId) override;

void resolveNode(ErrorString*, int nodeId, const String* objectGroup, RefPtr<TypeBuilder::Runtime::RemoteObject>& result) override;

void getAttributes(ErrorString*, int nodeId, RefPtr<TypeBuilder::Array<String>>& result) override;

- void setInspectModeEnabled(ErrorString*, bool enabled, const bool* inspectUAShadowDOM, const RefPtr<JSONObject>* highlightConfig) override;

+ void setInspectMode(ErrorString*, const String&, const RefPtr<JSONObject>* highlightConfig) override;

void requestNode(ErrorString*, const String& objectId, int* nodeId) override;

void pushNodeByPathToFrontend(ErrorString*, const String& path, int* nodeId) override;

void pushNodesByBackendIdsToFrontend(ErrorString*, const RefPtr<JSONArray>& nodeIds, RefPtr<TypeBuilder::Array<int>>&) override;

« no previous file with comments | « LayoutTests/inspector/elements/inspect-pseudo-element.html ('k') | Source/core/inspector/InspectorDOMAgent.cpp » ('j') | no next file with comments »