Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5305)

Unified Diff: chrome/browser/banners/app_banner_manager.h

Issue 1310223002: webapps: initial addition of splash screen icon downloading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-database-exp
Patch Set: Fix compile Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher.cc ('k') | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_manager.h
diff --git a/chrome/browser/banners/app_banner_manager.h b/chrome/browser/banners/app_banner_manager.h
index c1046a834f538dbe2aa1e03aa7c007720e93f45c..97623e4fa2ac59aae3686df86de723cfb7c93fc5 100644
--- a/chrome/browser/banners/app_banner_manager.h
+++ b/chrome/browser/banners/app_banner_manager.h
@@ -38,7 +38,7 @@ class AppBannerManager : public content::WebContentsObserver,
// Returns whether or not the URLs match for everything except for the ref.
static bool URLsAreForTheSamePage(const GURL& first, const GURL& second);
- explicit AppBannerManager(int icon_size);
+ explicit AppBannerManager(int ideal_icon_size_in_dp);
~AppBannerManager() override;
// WebContentsObserver overrides.
@@ -51,20 +51,21 @@ class AppBannerManager : public content::WebContentsObserver,
const GURL& validated_url) override;
protected:
- AppBannerManager(content::WebContents* web_contents, int icon_size);
+ AppBannerManager(content::WebContents* web_contents,
+ int ideal_icon_size_in_dp);
void ReplaceWebContents(content::WebContents* web_contents);
// Creates an AppBannerDataFetcher, which constructs an app banner.
virtual AppBannerDataFetcher* CreateAppBannerDataFetcher(
base::WeakPtr<AppBannerDataFetcher::Delegate> weak_delegate,
- const int ideal_icon_size) = 0;
+ const int ideal_icon_size_in_dp) = 0;
// Return whether the AppBannerDataFetcher is active.
bool IsFetcherActive();
scoped_refptr<AppBannerDataFetcher> data_fetcher() { return data_fetcher_; }
- int ideal_icon_size() { return ideal_icon_size_; }
+ int ideal_icon_size_in_dp() const { return ideal_icon_size_in_dp_; }
private:
// AppBannerDataFetcher::Delegate overrides.
@@ -83,7 +84,7 @@ class AppBannerManager : public content::WebContentsObserver,
void CancelActiveFetcher();
// Ideal icon size to use.
- const int ideal_icon_size_;
+ const int ideal_icon_size_in_dp_;
// The type of navigation made to the page
ui::PageTransition last_transition_type_;
« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher.cc ('k') | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698