Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.cc

Issue 1310223002: webapps: initial addition of splash screen icon downloading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-database-exp
Patch Set: Fix compile Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher.h ('k') | chrome/browser/banners/app_banner_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_data_fetcher.cc
diff --git a/chrome/browser/banners/app_banner_data_fetcher.cc b/chrome/browser/banners/app_banner_data_fetcher.cc
index edaeb19b73c8c368eae2610b25f9c2d814fe3110..21e29df41b928b79dd8ce2651a5b76bef3fc8bcb 100644
--- a/chrome/browser/banners/app_banner_data_fetcher.cc
+++ b/chrome/browser/banners/app_banner_data_fetcher.cc
@@ -74,9 +74,9 @@ void AppBannerDataFetcher::SetTimeDeltaForTesting(int days) {
AppBannerDataFetcher::AppBannerDataFetcher(
content::WebContents* web_contents,
base::WeakPtr<Delegate> delegate,
- int ideal_icon_size)
+ int ideal_icon_size_in_dp)
: WebContentsObserver(web_contents),
- ideal_icon_size_(ideal_icon_size),
+ ideal_icon_size_in_dp_(ideal_icon_size_in_dp),
weak_delegate_(delegate),
is_active_(false),
was_canceled_by_page_(false),
@@ -319,7 +319,7 @@ void AppBannerDataFetcher::OnHasServiceWorker(
GURL icon_url =
ManifestIconSelector::FindBestMatchingIcon(
web_app_data_.icons,
- ideal_icon_size_,
+ ideal_icon_size_in_dp_,
gfx::Screen::GetScreenFor(web_contents->GetNativeView()));
if (!FetchAppIcon(web_contents, icon_url)) {
@@ -333,7 +333,7 @@ bool AppBannerDataFetcher::FetchAppIcon(content::WebContents* web_contents,
return ManifestIconDownloader::Download(
web_contents,
icon_url,
- ideal_icon_size_,
+ ideal_icon_size_in_dp_,
base::Bind(&AppBannerDataFetcher::OnAppIconFetched,
this));
}
« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher.h ('k') | chrome/browser/banners/app_banner_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698