Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 1310223002: webapps: initial addition of splash screen icon downloading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-database-exp
Patch Set: Fix compile Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_manager.h ('k') | chrome/test/data/banners/image-512px.png » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index 0f5efab72a203974b3e215b03b76f616d524cee4..100d0645e9a8c0888ac7eeac81be8f372133b58d 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -27,17 +27,17 @@ bool AppBannerManager::URLsAreForTheSamePage(const GURL& first,
first.path() == second.path() && first.query() == second.query();
}
-AppBannerManager::AppBannerManager(int icon_size)
- : ideal_icon_size_(icon_size),
+AppBannerManager::AppBannerManager(int ideal_icon_size_in_dp)
+ : ideal_icon_size_in_dp_(ideal_icon_size_in_dp),
data_fetcher_(nullptr),
weak_factory_(this) {
AppBannerSettingsHelper::UpdateFromFieldTrial();
}
AppBannerManager::AppBannerManager(content::WebContents* web_contents,
- int icon_size)
+ int ideal_icon_size_in_dp)
: content::WebContentsObserver(web_contents),
- ideal_icon_size_(icon_size),
+ ideal_icon_size_in_dp_(ideal_icon_size_in_dp),
data_fetcher_(nullptr),
weak_factory_(this) {
AppBannerSettingsHelper::UpdateFromFieldTrial();
@@ -75,7 +75,7 @@ void AppBannerManager::DidFinishLoad(
// Kick off the data retrieval pipeline.
data_fetcher_ = CreateAppBannerDataFetcher(weak_factory_.GetWeakPtr(),
- ideal_icon_size_);
+ ideal_icon_size_in_dp_);
data_fetcher_->Start(validated_url, last_transition_type_);
}
« no previous file with comments | « chrome/browser/banners/app_banner_manager.h ('k') | chrome/test/data/banners/image-512px.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698