Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.h

Issue 1310223002: webapps: initial addition of splash screen icon downloading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-database-exp
Patch Set: Fix compile Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_data_fetcher.h
diff --git a/chrome/browser/banners/app_banner_data_fetcher.h b/chrome/browser/banners/app_banner_data_fetcher.h
index 69d647e801219a4ca5e2d304d6819025094c777a..6d06e56bfe0af61b9b4b6c632645c8f509c39a84 100644
--- a/chrome/browser/banners/app_banner_data_fetcher.h
+++ b/chrome/browser/banners/app_banner_data_fetcher.h
@@ -57,7 +57,7 @@ class AppBannerDataFetcher
AppBannerDataFetcher(content::WebContents* web_contents,
base::WeakPtr<Delegate> weak_delegate,
- int ideal_icon_size);
+ int ideal_icon_size_in_dp);
// Begins creating a banner for the URL being displayed by the Delegate's
// WebContents.
@@ -119,10 +119,6 @@ class AppBannerDataFetcher
void OnRequestShowAppBanner(content::RenderFrameHost* render_frame_host,
int request_id);
- // Called when it is determined that the webapp has fulfilled the initial
- // criteria of having a manifest and a service worker.
- void OnHasServiceWorker(content::WebContents* web_contents);
-
content::WebContents* GetWebContents();
virtual std::string GetAppIdentifier();
const content::Manifest& web_app_data() { return web_app_data_; }
@@ -143,6 +139,10 @@ class AppBannerDataFetcher
void OnDidCheckHasServiceWorker(bool has_service_worker);
void OnAppIconFetched(const SkBitmap& bitmap);
+ // Called when it is determined that the webapp has fulfilled the initial
+ // criteria of having a manifest and a service worker.
+ void OnHasServiceWorker(content::WebContents* web_contents);
+
// Returns whether the given web app has already been installed.
// Implemented on desktop platforms only.
virtual bool IsWebAppInstalled(content::BrowserContext* browser_context,
@@ -169,7 +169,7 @@ class AppBannerDataFetcher
static bool IsManifestValidForWebApp(const content::Manifest& manifest,
content::WebContents* web_contents);
- const int ideal_icon_size_;
+ const int ideal_icon_size_in_dp_;
const base::WeakPtr<Delegate> weak_delegate_;
base::ObserverList<Observer> observer_list_;
bool is_active_;
« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc ('k') | chrome/browser/banners/app_banner_data_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698