Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 131013002: IDL compiler: EventHandler attributes in Node interfaces (Closed)

Created:
6 years, 11 months ago by Nils Barth (inactive)
Modified:
6 years, 11 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

IDL compiler: EventHandler attributes in Node interfaces Add test file for Node interfaces. Also simplification of the hard-coded DOM Node list; I should be able to eliminate this in Python thanks to interfaces_info (in followup). BUG=239771 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164761

Patch Set 1 #

Patch Set 2 : Fix typo #

Total comments: 6

Patch Set 3 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -129 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 2 2 chunks +21 lines, -19 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_types.py View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M Source/bindings/templates/attributes.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/bindings/tests/idls/TestInterfaceNode.idl View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
M Source/bindings/tests/idls/TestNode.idl View 1 chunk +1 line, -1 line 0 comments Download
A + Source/bindings/tests/results/V8TestInterfaceNode.h View 1 2 1 chunk +32 lines, -30 lines 0 comments Download
A + Source/bindings/tests/results/V8TestInterfaceNode.cpp View 1 2 6 chunks +46 lines, -73 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nils Barth (inactive)
6 years, 11 months ago (2014-01-09 07:19:47 UTC) #1
haraken
LGTM. https://codereview.chromium.org/131013002/diff/30001/Source/bindings/scripts/code_generator_v8.pm File Source/bindings/scripts/code_generator_v8.pm (right): https://codereview.chromium.org/131013002/diff/30001/Source/bindings/scripts/code_generator_v8.pm#newcode205 Source/bindings/scripts/code_generator_v8.pm:205: my %domNodeTypes = ("Attr" => 1, This list ...
6 years, 11 months ago (2014-01-09 07:44:59 UTC) #2
Nils Barth (inactive)
https://codereview.chromium.org/131013002/diff/30001/Source/bindings/scripts/code_generator_v8.pm File Source/bindings/scripts/code_generator_v8.pm (right): https://codereview.chromium.org/131013002/diff/30001/Source/bindings/scripts/code_generator_v8.pm#newcode205 Source/bindings/scripts/code_generator_v8.pm:205: my %domNodeTypes = ("Attr" => 1, On 2014/01/09 07:45:00, ...
6 years, 11 months ago (2014-01-09 07:49:11 UTC) #3
haraken
Still LGTM https://codereview.chromium.org/131013002/diff/30001/Source/bindings/scripts/code_generator_v8.pm File Source/bindings/scripts/code_generator_v8.pm (right): https://codereview.chromium.org/131013002/diff/30001/Source/bindings/scripts/code_generator_v8.pm#newcode205 Source/bindings/scripts/code_generator_v8.pm:205: my %domNodeTypes = ("Attr" => 1, On ...
6 years, 11 months ago (2014-01-09 07:50:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/131013002/110001
6 years, 11 months ago (2014-01-09 08:26:14 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 10:46:36 UTC) #6
Message was sent while issue was closed.
Change committed as 164761

Powered by Google App Engine
This is Rietveld 408576698