Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 131013002: IDL compiler: EventHandler attributes in Node interfaces (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rename Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/unstable/v8_types.py ('k') | Source/bindings/tests/idls/TestInterfaceNode.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/attributes.cpp
diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp
index 8dd0e4cb9cabe477cd8734e3591c875ffba0c8d3..3ae0812934d34fb272469341ddb621a488452328 100644
--- a/Source/bindings/templates/attributes.cpp
+++ b/Source/bindings/templates/attributes.cpp
@@ -145,7 +145,7 @@ v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info
{% endif %}
{% if attribute.idl_type != 'EventHandler' %}
{{attribute.v8_value_to_local_cpp_value}};
- {% else %}{# EventHandler hack #}
+ {% elif not is_node %}{# EventHandler hack #}
transferHiddenDependency(info.Holder(), {{attribute.event_handler_getter_expression}}, jsValue, {{v8_class}}::eventListenerCacheIndex, info.GetIsolate());
{% endif %}
{% if attribute.enum_validation_expression %}
« no previous file with comments | « Source/bindings/scripts/unstable/v8_types.py ('k') | Source/bindings/tests/idls/TestInterfaceNode.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698