Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309813002: Deprecate useless CompilationInfo::IsOptimizable predicate. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-compilation-info-flags
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Deprecate useless CompilationInfo::IsOptimizable predicate. R=titzer@chromium.org Committed: https://crrev.com/201706bc91bec99401d53db2d6e737e529d5cb3c Cr-Commit-Position: refs/heads/master@{#30309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M src/compiler.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1304053004 Patch 20001

Dependent Patchsets:

Issue 1310603002 Patch 1

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-21 14:58:32 UTC) #1
titzer
On 2015/08/21 14:58:32, Michael Starzinger wrote: lgtm
5 years, 4 months ago (2015-08-21 15:09:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309813002/1
5 years, 4 months ago (2015-08-21 15:13:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-21 15:21:17 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 15:21:39 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/201706bc91bec99401d53db2d6e737e529d5cb3c
Cr-Commit-Position: refs/heads/master@{#30309}

Powered by Google App Engine
This is Rietveld 408576698