Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304053004: Deprecate semi-correct CompilationInfo::flags predicate. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Deprecate semi-correct CompilationInfo::flags predicate. R=titzer@chromium.org Committed: https://crrev.com/ef2fd24e9fc66513546ddef940c4b4d36dc94a61 Cr-Commit-Position: refs/heads/master@{#30308}

Patch Set 1 #

Patch Set 2 : Fix test-pipeline.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -19 lines) Patch
M src/codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/codegen.cc View 1 chunk +9 lines, -1 line 0 comments Download
M src/compiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/lithium.cc View 1 chunk +1 line, -3 lines 0 comments Download
M test/cctest/compiler/test-pipeline.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1309813002 Patch 1

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-21 14:02:13 UTC) #1
titzer
lgtm
5 years, 4 months ago (2015-08-21 14:04:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304053004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304053004/20001
5 years, 4 months ago (2015-08-21 14:59:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-21 15:10:45 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 15:11:08 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ef2fd24e9fc66513546ddef940c4b4d36dc94a61
Cr-Commit-Position: refs/heads/master@{#30308}

Powered by Google App Engine
This is Rietveld 408576698