src/compiler.h - Issue 1309813002: Deprecate useless CompilationInfo::IsOptimizable predicate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.h

Issue 1309813002: Deprecate useless CompilationInfo::IsOptimizable predicate. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-compilation-info-flags

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler.h

diff --git a/src/compiler.h b/src/compiler.h

index ea311cccfb0d4d96d0550a4216f38cd14401d4bd..8ac0eea7efb306468ea76dc8b85b0f8fffeaf454 100644

--- a/src/compiler.h

+++ b/src/compiler.h

@@ -292,7 +292,6 @@ class CompilationInfo {

// Accessors for the different compilation modes.

bool IsOptimizing() const { return mode_ == OPTIMIZE; }

- bool IsOptimizable() const { return mode_ == BASE; }

bool IsStub() const { return mode_ == STUB; }

void SetOptimizing(BailoutId osr_ast_id, Handle<Code> unoptimized) {

DCHECK(!shared_info().is_null());

@@ -317,7 +316,7 @@ class CompilationInfo {

return GetFlag(kDeoptimizationSupport);

}

void EnableDeoptimizationSupport() {

- DCHECK(IsOptimizable());

+ DCHECK_EQ(BASE, mode_);

SetFlag(kDeoptimizationSupport);

}

« no previous file with comments | « no previous file | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »