Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309273006: Remove unused WebNotificationData constructor (Closed)

Created:
5 years, 3 months ago by johnme
Modified:
5 years, 3 months ago
Reviewers:
Peter Beverloo
CC:
blink-reviews, peter+watch_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove unused WebNotificationData constructor Depends on https://codereview.chromium.org/1316093003 BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201309

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use in-class initializers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -22 lines) Patch
M public/platform/modules/notifications/WebNotificationData.h View 1 1 chunk +2 lines, -22 lines 0 comments Download

Dependent Patchsets:

Issue 1309273007 Patch 1

Messages

Total messages: 8 (3 generated)
johnme
5 years, 3 months ago (2015-08-26 15:25:26 UTC) #2
Peter Beverloo
lgtm % comment Thank you John!! :) https://codereview.chromium.org/1309273006/diff/1/public/platform/modules/notifications/WebNotificationData.h File public/platform/modules/notifications/WebNotificationData.h (left): https://codereview.chromium.org/1309273006/diff/1/public/platform/modules/notifications/WebNotificationData.h#oldcode24 public/platform/modules/notifications/WebNotificationData.h:24: : direction(DirectionLeftToRight) ...
5 years, 3 months ago (2015-08-26 15:28:59 UTC) #3
johnme
https://codereview.chromium.org/1309273006/diff/1/public/platform/modules/notifications/WebNotificationData.h File public/platform/modules/notifications/WebNotificationData.h (left): https://codereview.chromium.org/1309273006/diff/1/public/platform/modules/notifications/WebNotificationData.h#oldcode24 public/platform/modules/notifications/WebNotificationData.h:24: : direction(DirectionLeftToRight) On 2015/08/26 15:28:59, Peter Beverloo wrote: > ...
5 years, 3 months ago (2015-08-26 15:32:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309273006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309273006/20001
5 years, 3 months ago (2015-08-27 10:49:05 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 12:01:17 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201309

Powered by Google App Engine
This is Rietveld 408576698