Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1316093003:
Remove last usage of WebNotificationData constructor with arguments (Closed)
|
Created:
5 years, 3 months ago by johnme Modified:
5 years, 3 months ago Reviewers:
Peter Beverloo CC:
chromium-reviews, darin-cc_chromium.org, peter+watch_chromium.org, jam, mlamouri+watch-notifications_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove last usage of WebNotificationData constructor with arguments
All other callers use the no-argument WebNotificationData constructor.
Standardizing on that will simplify future 3-sided patches.
BUG=none
NOTRY=true
Committed: https://crrev.com/fc38fb660e54fd65834e855d1cf8a8db3329bc69
Cr-Commit-Position: refs/heads/master@{#345617}
Patch Set 1 #
Total comments: 1
Dependent Patchsets: Messages
Total messages: 24 (10 generated)
johnme@chromium.org changed reviewers: + peter@chromium.org
https://codereview.chromium.org/1316093003/diff/1/content/child/notifications... File content/child/notifications/notification_data_conversions_unittest.cc (right): https://codereview.chromium.org/1316093003/diff/1/content/child/notifications... content/child/notifications/notification_data_conversions_unittest.cc:46: static_cast<size_t>(2)); nit: 2u?
The CQ bit was checked by peter@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316093003/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by peter@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316093003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by johnme@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316093003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by johnme@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316093003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by johnme@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316093003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fc38fb660e54fd65834e855d1cf8a8db3329bc69 Cr-Commit-Position: refs/heads/master@{#345617} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
