Issue 1308773002: ManagePasswordsState should ignore the blacklisted forms.

Issue 1308773002: ManagePasswordsState should ignore the blacklisted forms. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
2 years, 1 month ago by vasilii

Modified:
2 years, 1 month ago

Reviewers:
melandory

CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

ManagePasswordsState should ignore the blacklisted forms. BUG=493257 Committed: https://crrev.com/d9ff6d21e187712f52ae35cacbba8f693f77427b Cr-Commit-Position: refs/heads/master@{#344758}

Patch Set 1 #

Created: 2 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/ui/passwords/manage_passwords_state.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/passwords/manage_passwords_state_unittest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Trybot results: win_chromium_x64_rel_ng chromium_presubmit win_chromium_x64_rel_ng win_chromium_x64_rel_ng chromium_presubmit win_chromium_x64_rel_ng win_chromium_rel_ng win8_chromium_ng win_chromium_compile_dbg_ng mac_chromium_rel_ng mac_chromium_compile_dbg_ng ios_rel_device_ninja ios_dbg_simulator_ninja linux_chromium_rel_ng linux_chromium_gn_rel linux_chromium_gn_dbg linux_chromium_gn_chromeos_rel linux_chromium_clobber_rel_ng linux_chromium_compile_dbg_32_ng linux_chromium_chromeos_rel_ng linux_chromium_chromeos_ozone_rel_ng linux_chromium_chromeos_compile_dbg_ng linux_chromium_asan_rel_ng linux_android_rel_ng chromeos_daisy_chromium_compile_only_ng chromeos_x86-generic_chromium_compile_only_ng cast_shell_linux chromeos_amd64-generic_chromium_compile_only_ng cast_shell_android android_compile_dbg android_chromium_gn_compile_rel android_clang_dbg_recipe android_arm64_dbg_recipe android_chromium_gn_compile_dbg

Commit queue not available (can’t edit this change).

Messages

Total messages: 11 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

melandory

On 2015/08/21 09:34:39, vasilii wrote: > Hi Tanya, > > please review the CL. lgtm

2 years, 1 month ago (2015-08-21 11:29:53 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308773002/1

2 years, 1 month ago (2015-08-21 11:35:35 UTC) #5

commit-bot: I haz the power

Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/93871)

2 years, 1 month ago (2015-08-21 13:08:49 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308773002/1

2 years, 1 month ago (2015-08-21 13:10:20 UTC) #9

commit-bot: I haz the power

2 years, 1 month ago (2015-08-21 13:47:53 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d9ff6d21e187712f52ae35cacbba8f693f77427b
Cr-Commit-Position: refs/heads/master@{#344758}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages