chrome/browser/ui/passwords/manage_passwords_state.cc - Issue 1308773002: ManagePasswordsState should ignore the blacklisted forms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_state.cc

Issue 1308773002: ManagePasswordsState should ignore the blacklisted forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/passwords/manage_passwords_state.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_state.cc b/chrome/browser/ui/passwords/manage_passwords_state.cc

index a7e893ae68f8c36fca8f7da8121f5e79f032e51b..dda3d3ade7fd5b68dfb15202c60716813a3fc9a3 100644

--- a/chrome/browser/ui/passwords/manage_passwords_state.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_state.cc

@@ -188,6 +188,8 @@ void ManagePasswordsState::ProcessLoginsChanged(

for (const password_manager::PasswordStoreChange& change : changes) {

const autofill::PasswordForm& changed_form = change.form();

+ if (changed_form.blacklisted_by_user)

+ continue;

if (change.type() == password_manager::PasswordStoreChange::REMOVE) {

DeleteForm(changed_form);

} else {

« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_state_unittest.cc » ('j') | no next file with comments »