Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 1308623003: Assume crashed RenderWidgetHost to be invisible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Assume dead RenderWidgetHost to be invisible Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.cc
diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc
index c2ef320311620f6587e9483f41ed7abcb146846c..5175678c81c32c3b92701d5233daa4e42c08fcda 100644
--- a/content/browser/frame_host/render_frame_host_manager.cc
+++ b/content/browser/frame_host/render_frame_host_manager.cc
@@ -427,6 +427,17 @@ RenderFrameHostImpl* RenderFrameHostManager::Navigate(
if (dest_render_frame_host->GetView())
dest_render_frame_host->GetView()->Hide();
} else {
+#if defined(OS_ANDROID)
no sievers 2015/09/01 18:30:54 Can we remove the ifdef Android? There shouldn't b
Jaekyun Seok (inactive) 2015/09/02 01:25:49 Removed. I tested on AURA Linux manually, and con
+ if (dest_render_frame_host->GetView()) {
+ if (dest_render_frame_host->GetView()->IsShowing() ==
+ delegate_->IsHidden()) {
+ if (delegate_->IsHidden())
+ dest_render_frame_host->GetView()->Hide();
+ else
+ dest_render_frame_host->GetView()->Show();
+ }
+ }
+#endif
// TODO(nasko): This is a very ugly hack. The Chrome extensions process
// manager still uses NotificationService and expects to see a
// RenderViewHost changed notification after WebContents and

Powered by Google App Engine
This is Rietveld 408576698