Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 1308623003: Assume crashed RenderWidgetHost to be invisible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Assume dead RenderWidgetHost to be invisible Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index cbc3c976dcad02fc8ebe002fc0c245b78e74cd17..50f300b912ad9434873a74cce7de96ae22de988c 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -1256,10 +1256,20 @@ void RenderWidgetHostImpl::RendererExited(base::TerminationStatus status,
// We need to at least make sure that the RenderProcessHost is notified about
// the |is_hidden_| change, so that the renderer will have correct visibility
// set when respawned.
+//
+// http://crbug.com/522795 : On Android, we assume dead RenderWidgetHost to be
+// invisible to correctly keep the priority of a restored renderer.
+#if defined(OS_ANDROID)
no sievers 2015/09/01 18:30:54 Can we just remove 1260-1272?
Jaekyun Seok (inactive) 2015/09/02 01:25:50 Done.
+ if (!is_hidden_) {
+ process_->WidgetHidden();
+ is_hidden_ = true;
+ }
+#else
if (is_hidden_) {
process_->WidgetRestored();
is_hidden_ = false;
}
+#endif
// Reset this to ensure the hung renderer mechanism is working properly.
in_flight_event_count_ = 0;

Powered by Google App Engine
This is Rietveld 408576698