Assume crashed RenderWidgetHost to be invisible

content/browser/frame_host/render_frame_host_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_manager.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/command_line.h"
@@ skipping 409 matching lines @@
                         frame_tree_node_->IsMainFrame()))
       return nullptr;
 
     // Now that we've created a new renderer, be sure to hide it if it isn't
     // our primary one.  Otherwise, we might crash if we try to call Show()
     // on it later.
     if (dest_render_frame_host != render_frame_host_) {
       if (dest_render_frame_host->GetView())
         dest_render_frame_host->GetView()->Hide();
     } else {
+#if defined(OS_ANDROID)

[no sievers, 2015/09/01 18:30:54]

Can we remove the ifdef Android?
There shouldn't be a difference in behavior. And 'defined(AURA) &&
defined(OS_ANDROID)' needs to be working also.

You can try on AURA Linux and see if that works for crashed tabs.

In other words I was wondering if the fix could just be to 'remove the
visibility workaround for when the renderer crashes, and instead set the
visibility correctly, according to what the app thinks the visibility should be,
when we reload the crashed tab'.

[Jaekyun Seok (inactive), 2015/09/02 01:25:49]

Removed.

I tested on AURA Linux manually, and confirmed that it worked.

+      if (dest_render_frame_host->GetView()) {
+        if (dest_render_frame_host->GetView()->IsShowing() ==
+            delegate_->IsHidden()) {
+          if (delegate_->IsHidden())
+            dest_render_frame_host->GetView()->Hide();
+          else
+            dest_render_frame_host->GetView()->Show();
+        }
+      }
+#endif
       // TODO(nasko): This is a very ugly hack. The Chrome extensions process
       // manager still uses NotificationService and expects to see a
       // RenderViewHost changed notification after WebContents and
       // RenderFrameHostManager are completely initialized. This should be
       // removed once the process manager moves away from NotificationService.
       // See https://crbug.com/462682.
       delegate_->NotifyMainFrameSwappedFromRenderManager(
           nullptr, render_frame_host_->render_view_host());
     }
   }
@@ skipping 2121 matching lines @@
 int RenderFrameHostManager::GetOpenerRoutingID(SiteInstance* instance) {
   if (!frame_tree_node_->opener())
     return MSG_ROUTING_NONE;
 
   return frame_tree_node_->opener()
       ->render_manager()
       ->GetRoutingIdForSiteInstance(instance);
 }
 
 }  // namespace content