Dirty line boxes correctly when a float gets layout

Dirty line boxes correctly when a float gets layout

Using dirtyLinesFromChangedChild() was the wrong choice in
https://codereview.chromium.org/1167543008 as it can dirty the
lineboxes of descendants and ancestors. We're only interested
in dirtying the lineboxes of the current parent as it is
only to one of them we will possibly attach the float.

I have more to do here to understand why I'm not getting a
height on the span in my new test, but this successfully
addresses the assert in bug 510703 and seems obviously more
correct than what I currently have.


BUG=510703
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201025

[rhogan, 2015-08-21 13:13:16]

robhogan@gmail.com changed reviewers:
+ eae@chromium.org

[rhogan, 2015-08-21 13:15:29]

https://codereview.chromium.org/1308433003/diff/1/Source/core/layout/LayoutBl...
File Source/core/layout/LayoutBlockFlowLine.cpp (right):

https://codereview.chromium.org/1308433003/diff/1/Source/core/layout/LayoutBl...
Source/core/layout/LayoutBlockFlowLine.cpp:1552:
markLinesDirtyInBlockRange(toLayoutBox(o)->logicalTop(),
toLayoutBox(o)->logicalBottom());
Oops, I should use |box| here. I'll address that when landing if everything else
is OK.

[eae, 2015-08-21 18:43:33]

LGTM
Step in the right direction, would be great if we could finally get to the
bottom of this class of problems.

[rhogan, 2015-08-21 20:14:37]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2015-08-21 20:14:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308433003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308433003/1

[commit-bot: I haz the power, 2015-08-21 23:15:10]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201025