Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1298603004: Ensure floats get added to floating objects list even if they don't have a linebox (Closed)

Created:
5 years, 4 months ago by rhogan
Modified:
5 years, 4 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Ensure floats get added to floating objects list even if they don't have a linebox In https://codereview.chromium.org/1132103007 the problem with the trailing float in fast/block/float/trailing-float.html is that it doesn't have a linebox, so when line layout is run on a selection of dirty lineboxes on the parent it is not re-added to the floating objects list and so doesn't get a paint. So the correct fix is to ensure any floats not added to the floating objects list during line layout are added, rather than to attempt to dirty more lines in the hope that line layout will hit the float, add it to the floats list and so ensure it gets a paint. BUG=510703 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200915

Patch Set 1 #

Patch Set 2 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
A LayoutTests/fast/block/float/trailing-float-layout.html View 1 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fast/block/float/trailing-float-layout-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutBlockFlowLine.cpp View 3 chunks +3 lines, -8 lines 0 comments Download

Depends on Patchset:

Issue 1293023002 Patch 1

Dependent Patchsets:

Issue 1308433003 Patch 1

Messages

Total messages: 10 (4 generated)
rhogan
5 years, 4 months ago (2015-08-19 20:49:40 UTC) #2
eae
LGTM I like it, thanks for taking the time to track down the root cause!
5 years, 4 months ago (2015-08-19 20:58:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298603004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298603004/20001
5 years, 4 months ago (2015-08-20 09:46:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/95937)
5 years, 4 months ago (2015-08-20 13:50:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298603004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298603004/20001
5 years, 4 months ago (2015-08-20 15:26:34 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 17:54:04 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200915

Powered by Google App Engine
This is Rietveld 408576698