Dirty nearby lineboxes if we layout a float rather than trying to work it out later

Dirty nearby lineboxes if we layout a float rather than trying to work it out later

This is a simpler, but necessarily broader-brushed, approach to linebox dirtying
when floats are present than the one we have currently. If it doesn't create performance
problems after baking for a while there is a lot of stuff I think we can rip out
of the line layout code as a lot of the current complexity relates to figuring
out what lineboxes to dirty when floats are nearby.

BUG=491866
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198739

[rhogan, 2015-07-06 18:46:13]

robhogan@gmail.com changed reviewers:
+ leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-07-07 21:09:28]

Umm... yes! \o/

I think this is a great idea. LGTM with a nit.

https://codereview.chromium.org/1167543008/diff/1/LayoutTests/TestExpectations
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1167543008/diff/1/LayoutTests/TestExpectation...
LayoutTests/TestExpectations:1308: crbug.com/491866
fast/repaint/line-flow-with-floats-10.html [ NeedsRebaseline ]
You need the slimming-paint ones as well.

https://codereview.chromium.org/1167543008/diff/1/LayoutTests/fast/block/floa...
File LayoutTests/fast/block/float/float-inserted-into-clean-line-expected.txt
(right):

https://codereview.chromium.org/1167543008/diff/1/LayoutTests/fast/block/floa...
LayoutTests/fast/block/float/float-inserted-into-clean-line-expected.txt:4:
uuO,*MkR41 KE? , Wm?_8)}ej 0r{H!= ^.Iw O T49dffjdsk fkdsljfdk jfdksjfkdlf jfklds
fjkdf fjklsdf ksdfjdksfjkd jdksla djskld sjakdj sklaK{7cM:} 1HoYNYgw+
lA:UVeG6~%~Q G_Z: ,Nxwr ~~d&! ILugpV4yR 7Q=zX iFhmm2 ;WSubT4o0 t` -F=. qsDYER
U6Pm({x g=Q	O, .V Au : ] ;/X57^{ k14[1p%{))kT-X. 1h%{T J$%~ u@ hHcWwy`CO(	$3Dd
Can we clean up this output after we've done our final layout and not crashed?

https://codereview.chromium.org/1167543008/diff/1/LayoutTests/fast/block/floa...
File LayoutTests/fast/block/float/float-inserted-into-clean-line.html (right):

https://codereview.chromium.org/1167543008/diff/1/LayoutTests/fast/block/floa...
LayoutTests/fast/block/float/float-inserted-into-clean-line.html:31: if
(window.testRunner) {
Nit: unnecessary braces

[rhogan, 2015-07-11 13:01:34]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2015-07-11 13:01:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1167543008/1

[commit-bot: I haz the power, 2015-07-11 13:04:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-11 13:04:07]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/62558)

[rhogan, 2015-07-11 15:52:25]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2015-07-11 15:52:25]

The patchset sent to the CQ was uploaded after l-g-t-m from leviw@chromium.org
Link to the patchset: https://codereview.chromium.org/1167543008/#ps20001
(title: "Updated")

[commit-bot: I haz the power, 2015-07-11 15:52:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1167543008/20001

[commit-bot: I haz the power, 2015-07-11 17:14:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-11 17:14:16]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/62565)

[rhogan, 2015-07-12 08:40:31]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2015-07-12 08:40:32]

The patchset sent to the CQ was uploaded after l-g-t-m from leviw@chromium.org
Link to the patchset: https://codereview.chromium.org/1167543008/#ps40001
(title: "Updated")

[commit-bot: I haz the power, 2015-07-12 08:40:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1167543008/40001

[commit-bot: I haz the power, 2015-07-12 10:03:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-12 10:03:25]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/62569)

[rhogan, 2015-07-12 18:34:16]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2015-07-12 18:34:17]

The patchset sent to the CQ was uploaded after l-g-t-m from leviw@chromium.org
Link to the patchset: https://codereview.chromium.org/1167543008/#ps60001
(title: "Updated")

[commit-bot: I haz the power, 2015-07-12 18:34:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1167543008/60001

[commit-bot: I haz the power, 2015-07-12 19:56:11]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198739