Devtools [LayoutEditor]: Show medias for the rules with the same selectors

Source/core/inspector/LayoutEditor.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/inspector/LayoutEditor.h"
 
 #include "core/css/CSSComputedStyleDeclaration.h"
+#include "core/css/CSSImportRule.h"
+#include "core/css/CSSMediaRule.h"
 #include "core/css/CSSRuleList.h"
+#include "core/css/MediaList.h"
 #include "core/dom/NodeComputedStyle.h"
 #include "core/dom/StaticNodeList.h"
 #include "core/frame/FrameView.h"
 #include "core/inspector/InspectorCSSAgent.h"
 #include "core/inspector/InspectorDOMAgent.h"
 #include "core/inspector/InspectorHighlight.h"
 #include "core/layout/LayoutBox.h"
 #include "core/layout/LayoutInline.h"
 #include "core/layout/LayoutObject.h"
 #include "core/style/ComputedStyle.h"
@@ skipping 369 matching lines @@
         return m_cachedSelectorsInfo.get(m_currentRuleIndex);
 
     RefPtr<JSONObject> object = JSONObject::create();
     String currentSelectorText = m_currentRuleIndex == -1 ? "inline style" : m_matchedRules[m_currentRuleIndex]->selectorText();
     object->setString("selector", currentSelectorText);
 
     Document* ownerDocument = m_element->ownerDocument();
     if (!ownerDocument->isActive() || m_currentRuleIndex == -1)
         return object->toJSONString();
 
+    if (m_currentRuleIndex != -1) {
+        bool hasSameSelectors = false;
+        for (size_t i = 0; i < m_matchedRules.size(); i++)
+            hasSameSelectors |= i != static_cast<unsigned>(m_currentRuleIndex) && m_matchedRules[i]->selectorText() == currentSelectorText;

[dgozman, 2015/09/02 22:06:26]

if (i != ....)
   ...

[sergeyv, 2015/09/02 23:58:34]

Done.

+
+        if (hasSameSelectors) {
+            OwnPtr<Vector<String>> medias = buildMediaListChain(m_matchedRules[m_currentRuleIndex].get());
+            RefPtr<JSONArray> mediasJSONArray = JSONArray::create();
+            for (size_t i = 0; i < medias->size(); ++i)
+                mediasJSONArray->pushString(medias->at(i));
+
+            object->setArray("medias", mediasJSONArray.release());
+        }
+    }
+
     TrackExceptionState exceptionState;
     RefPtrWillBeRawPtr<StaticElementList> elements = ownerDocument->querySelectorAll(AtomicString(m_matchedRules[m_currentRuleIndex]->selectorText()), exceptionState);
 
     if (!elements || exceptionState.hadException())
         return object->toJSONString();
 
     RefPtr<JSONArray> highlights = JSONArray::create();
     InspectorHighlightConfig config = affectedNodesHighlightConfig();
     for (unsigned i = 0; i < elements->length(); ++i) {
         Element* element = elements->item(i);
         if (element == m_element)
             continue;
 
         InspectorHighlight highlight(element, config, false);
         highlights->pushObject(highlight.asJSONObject());
     }
 
     object->setArray("nodes", highlights.release());
     m_cachedSelectorsInfo.add(m_currentRuleIndex, object->toJSONString());
     return m_cachedSelectorsInfo.get(m_currentRuleIndex);
 }
 
+void LayoutEditor::collectMediaQueriesFromRule(CSSRule* rule, Vector<String>& mediaArray)
+{
+    MediaList* mediaList;
+    if (rule->type() == CSSRule::MEDIA_RULE) {
+        CSSMediaRule* mediaRule = toCSSMediaRule(rule);
+        mediaList = mediaRule->media();
+    } else if (rule->type() == CSSRule::IMPORT_RULE) {
+        CSSImportRule* importRule = toCSSImportRule(rule);
+        mediaList = importRule->media();
+    } else {
+        mediaList = nullptr;
+    }
+
+    if (mediaList && mediaList->length())
+        mediaArray.append(mediaList->mediaText());
+}
+
+PassOwnPtr<Vector<String>> LayoutEditor::buildMediaListChain(CSSRule* rule)

[dgozman, 2015/09/02 22:06:25]

Move to namespace.

[dgozman, 2015/09/02 22:06:26]

Let's follow the pattern of (..., Vector<String>&).

[sergeyv, 2015/09/02 23:58:34]

Done.

[sergeyv, 2015/09/02 23:58:34]

Done.

+{
+    if (!rule)
+        return nullptr;
+    CSSRule* parentRule = rule;
+    OwnPtr<Vector<String>> result = adoptPtr(new Vector<String>());
+    while (parentRule) {

[dgozman, 2015/09/02 22:06:25]

s/parentRule/rule

[sergeyv, 2015/09/02 23:58:34]

Done.

+        collectMediaQueriesFromRule(parentRule, *result.get());
+        if (parentRule->parentRule()) {
+            parentRule = parentRule->parentRule();
+        } else {
+            CSSStyleSheet* styleSheet = parentRule->parentStyleSheet();
+            while (styleSheet) {

[dgozman, 2015/09/02 22:06:25]

TODO: should be able to replace cycle by one iteration of it.

[sergeyv, 2015/09/02 23:58:34]

Done.

+                MediaList* mediaList = styleSheet->media();
+                if (mediaList && mediaList->length())
+                    result->append(mediaList->mediaText());
+
+                parentRule = styleSheet->ownerRule();
+                if (parentRule)
+                    break;
+                styleSheet = styleSheet->parentStyleSheet();
+            }
+        }
+    }
+    return result.release();
+}
+
 } // namespace blink