Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: components/cronet/android/cronet_histogram_manager.cc

Issue 1308363003: Revert of jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/cronet_histogram_manager.cc
diff --git a/components/cronet/android/cronet_histogram_manager.cc b/components/cronet/android/cronet_histogram_manager.cc
index ae0de70dd35431d08b431a5e23065057f7ad2e40..de1989bdef57b5537fe9b7b417712fa17c10eb62 100644
--- a/components/cronet/android/cronet_histogram_manager.cc
+++ b/components/cronet/android/cronet_histogram_manager.cc
@@ -24,12 +24,11 @@
base::StatisticsRecorder::Initialize();
}
-static ScopedJavaLocalRef<jbyteArray> GetHistogramDeltas(JNIEnv* env,
- jobject jcaller) {
+static jbyteArray GetHistogramDeltas(JNIEnv* env, jobject jcaller) {
std::vector<uint8> data;
if (!HistogramManager::GetInstance()->GetDeltas(&data))
- return ScopedJavaLocalRef<jbyteArray>();
- return base::android::ToJavaByteArray(env, &data[0], data.size());
+ return NULL;
+ return base::android::ToJavaByteArray(env, &data[0], data.size()).Release();
}
} // namespace cronet
« no previous file with comments | « components/cronet/android/chromium_url_request_context.cc ('k') | components/cronet/android/cronet_library_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698