components/cronet/android/cronet_library_loader.cc - Issue 1308363003: Revert of jni_generator: Make all object-returning natives return ScopedJavaLocalRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/cronet_library_loader.cc

Issue 1308363003: Revert of jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/cronet_histogram_manager.cc ('k') | components/cronet/android/test/mock_url_request_job_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/cronet_library_loader.cc

diff --git a/components/cronet/android/cronet_library_loader.cc b/components/cronet/android/cronet_library_loader.cc

index 8e38125344a4bab324b404b7f01453385a001f8a..ddc5f1ba4c958d220f3677ae8befafd7d0b508b4 100644

--- a/components/cronet/android/cronet_library_loader.cc

+++ b/components/cronet/android/cronet_library_loader.cc

@@ -113,8 +113,8 @@

g_network_change_notifier = net::NetworkChangeNotifier::Create();

}

-ScopedJavaLocalRef<jstring> GetCronetVersion(JNIEnv* env, jclass jcaller) {

- return base::android::ConvertUTF8ToJavaString(env, CRONET_VERSION);

+jstring GetCronetVersion(JNIEnv* env, jclass jcaller) {

+ return base::android::ConvertUTF8ToJavaString(env, CRONET_VERSION).Release();

}

} // namespace cronet