Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: components/cronet/android/chromium_url_request_context.cc

Issue 1308363003: Revert of jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/chromium_url_request_context.cc
diff --git a/components/cronet/android/chromium_url_request_context.cc b/components/cronet/android/chromium_url_request_context.cc
index d94f84d6d5ea963945d74be9381ac2a16e4752f1..b6817402df84ec4ea950658c1a56af382d3dfbb6 100644
--- a/components/cronet/android/chromium_url_request_context.cc
+++ b/components/cronet/android/chromium_url_request_context.cc
@@ -117,12 +117,12 @@
// Gets current statistics with |jfilter| as a substring as JSON text (an empty
// |jfilter| will include all registered histograms).
-static ScopedJavaLocalRef<jstring> GetStatisticsJSON(JNIEnv* env,
- jobject jcaller,
- jstring jfilter) {
+static jstring GetStatisticsJSON(JNIEnv* env,
+ jobject jcaller,
+ jstring jfilter) {
std::string query = ConvertJavaStringToUTF8(env, jfilter);
std::string json = base::StatisticsRecorder::ToJSON(query);
- return ConvertUTF8ToJavaString(env, json);
+ return ConvertUTF8ToJavaString(env, json).Release();
}
// Starts recording NetLog into file with |jfilename|.
« no previous file with comments | « components/cronet/android/chromium_url_request.cc ('k') | components/cronet/android/cronet_histogram_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698