chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm - Issue 1308293002: [Mac] Refactor bookmark pulsing into BookmarkBubbleObserverCocoa.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm

Issue 1308293002: [Mac] Refactor bookmark pulsing into BookmarkBubbleObserverCocoa. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarkeditor

Patch Set: Address comments. Update unit_tests. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm ('k') | chrome/browser/ui/cocoa/browser_window_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm

index 6b47a05070be987232e17f4ef11019dec440f471..52f7aae29e38048460e4388c52e787a937adc2b6 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm

@@ -81,10 +81,9 @@ using bookmarks::BookmarkNode;

- (void)runAsModalSheet {

// Ping me when things change out from under us.

observer_.reset(new BookmarkModelObserverForCocoa(

- BookmarkModelFactory::GetForProfile(profile_),

- ^(BOOL nodeWasDeleted) {

- [self cancel:nil];

- }));

+ BookmarkModelFactory::GetForProfile(profile_), ^() {

+ [self cancel:nil];

+ }));

observer_->StartObservingNode(node_);

[NSApp beginSheet:[self window]

modalForWindow:parentWindow_