chrome/browser/ui/cocoa/browser_window_controller.h - Issue 1308293002: [Mac] Refactor bookmark pulsing into BookmarkBubbleObserverCocoa.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.h

Issue 1308293002: [Mac] Refactor bookmark pulsing into BookmarkBubbleObserverCocoa. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarkeditor

Patch Set: Address comments. Update unit_tests. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm ('k') | chrome/browser/ui/cocoa/browser_window_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller.h

diff --git a/chrome/browser/ui/cocoa/browser_window_controller.h b/chrome/browser/ui/cocoa/browser_window_controller.h

index 60beb8bcc3ce0788c87027ba0c966be22e466781..0d4dbf272514fc1257e7dfa34259632fe0770ae8 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller.h

+++ b/chrome/browser/ui/cocoa/browser_window_controller.h

@@ -28,6 +28,7 @@

#include "ui/gfx/geometry/rect.h"

@class AvatarBaseController;

+class BookmarkBubbleObserverCocoa;

class Browser;

class BrowserWindow;

class BrowserWindowCocoa;

@@ -91,6 +92,7 @@ class Command;

// be shut down before our destructors are called.

StatusBubbleMac* statusBubble_;

+ scoped_ptr<BookmarkBubbleObserverCocoa> bookmarkBubbleObserver_;

BookmarkBubbleController* bookmarkBubbleController_; // Weak.

BOOL initializing_; // YES while we are currently in initWithBrowser:

BOOL ownsBrowser_; // Only ever NO when testing

@@ -360,6 +362,9 @@ class Command;

// coordinates.

- (NSPoint)bookmarkBubblePoint;

+// Called by BookmarkBubbleObserverCocoa when the bubble is closed.

+- (void)bookmarkBubbleClosed;

// Called when the Add Search Engine dialog is closed.

- (void)sheetDidEnd:(NSWindow*)sheet

returnCode:(NSInteger)code