Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm

Issue 1308293002: [Mac] Refactor bookmark pulsing into BookmarkBubbleObserverCocoa. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarkeditor
Patch Set: Address comments. Update unit_tests. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm
index bc3e161fb519c2a2efe96f50ce992ff1d1edfc6f..17450134954b34194e173ebe102e0bfb533043fc 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm
@@ -27,14 +27,10 @@ TEST_F(BookmarkModelObserverForCocoaTest, TestCallback) {
GURL("http://www.google.com"));
__block size_t pings = 0U;
- __block size_t deletions = 0U;
- BookmarkModelObserverForCocoa::ChangeCallback callback =
- ^(BOOL nodeWasDeleted) {
- ++pings;
- if (nodeWasDeleted)
- ++deletions;
- };
+ BookmarkModelObserverForCocoa::ChangeCallback callback = ^() {
+ ++pings;
+ };
scoped_ptr<BookmarkModelObserverForCocoa>
observer(new BookmarkModelObserverForCocoa(model,
@@ -42,23 +38,18 @@ TEST_F(BookmarkModelObserverForCocoaTest, TestCallback) {
observer->StartObservingNode(node);
EXPECT_EQ(0U, pings);
- EXPECT_EQ(0U, deletions);
model->SetTitle(node, base::ASCIIToUTF16("duper"));
EXPECT_EQ(1U, pings);
- EXPECT_EQ(0U, deletions);
model->SetURL(node, GURL("http://www.google.com/reader"));
EXPECT_EQ(2U, pings);
- EXPECT_EQ(0U, deletions);
model->Move(node, model->other_node(), 0);
EXPECT_EQ(3U, pings);
- EXPECT_EQ(0U, deletions);
model->Remove(node->parent()->GetChild(0));
EXPECT_EQ(4U, pings);
- EXPECT_EQ(1U, deletions);
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698