Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.mm

Issue 1308293002: [Mac] Refactor bookmark pulsing into BookmarkBubbleObserverCocoa. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarkeditor
Patch Set: Address comments. Update unit_tests. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.mm
index d9d6fab81599a424a966d6558ce2397ddad34904..3976e0f62f55735bc04ec30d0920ecc1a9ff34ce 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa.mm
@@ -32,7 +32,7 @@ void BookmarkModelObserverForCocoa::StopObservingNode(
void BookmarkModelObserverForCocoa::BookmarkModelBeingDeleted(
BookmarkModel* model) {
- Notify(YES);
+ Notify();
}
void BookmarkModelObserverForCocoa::BookmarkNodeMoved(
@@ -43,7 +43,7 @@ void BookmarkModelObserverForCocoa::BookmarkNodeMoved(
int new_index) {
// Editors often have a tree of parents, so movement of folders
// must cause a cancel.
- Notify(NO);
+ Notify();
}
void BookmarkModelObserverForCocoa::BookmarkNodeRemoved(
@@ -53,22 +53,22 @@ void BookmarkModelObserverForCocoa::BookmarkNodeRemoved(
const BookmarkNode* node,
const std::set<GURL>& removed_urls) {
// See comment in BookmarkNodeMoved.
- Notify(YES);
+ Notify();
}
void BookmarkModelObserverForCocoa::BookmarkAllUserNodesRemoved(
BookmarkModel* model,
const std::set<GURL>& removed_urls) {
- Notify(YES);
+ Notify();
}
void BookmarkModelObserverForCocoa::BookmarkNodeChanged(
BookmarkModel* model,
const BookmarkNode* node) {
if (!nodes_.size() || nodes_.find(node) != nodes_.end())
- Notify(NO);
+ Notify();
}
-void BookmarkModelObserverForCocoa::Notify(BOOL deleted) {
- callback_.get()(deleted);
+void BookmarkModelObserverForCocoa::Notify() {
+ callback_.get()();
}

Powered by Google App Engine
This is Rietveld 408576698